Page MenuHomePhabricator
Create Task
Maniphest T120630

Refactor TableWidget to use a proper model
Closed, ResolvedPublic40 Estimated Story Points
Actions

Description

The custom TableWidget used in graph-VE is pretty hackish right now, and could use a refactor. Namely, it is complex enough to warrant being used through a TableWidgetModel, which could have an easier-to-use API to manage adding/deleting rows/columns, smarter config options, etc etc. Lots of cool ideas.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Table widget modelmediawiki/extensions/Graphmaster+1 K -306
Customize query in gerrit

Event Timeline

• ferdbold created this task.Dec 7 2015, 4:26 AM
• ferdbold raised the priority of this task from to Needs Triage.
• ferdbold updated the task description. (Show Details)
• ferdbold added a project: MediaWiki-extensions-Graph.
• ferdbold moved this task to VisualEditor on the MediaWiki-extensions-Graph board.
• ferdbold subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 7 2015, 4:26 AM
gerritbot subscribed.Dec 7 2015, 4:42 AM

Change 254348 had a related patch set uploaded (by Ferdbold):
[WIP] Table widget model

https://gerrit.wikimedia.org/r/254348

gerritbot added a project: Patch-For-Review.Dec 7 2015, 4:42 AM
• ferdbold added subscribers: Esanders, Jdforrester-WMF.Mar 31 2016, 8:09 PM

Looking for review on this: @Esanders @Jdforrester-WMF ?

gerritbot added a comment.Oct 26 2016, 8:23 PM

Change 254348 merged by jenkins-bot:
Table widget model

https://gerrit.wikimedia.org/r/254348

Jdforrester-WMF closed this task as Resolved.Oct 26 2016, 8:25 PM
Jdforrester-WMF assigned this task to • ferdbold.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added VisualEditor; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 40.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF added a project: Technical-Debt.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Oct 26 2016, 9:00 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 4:00 PM
Jdforrester-WMF removed a project: MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)).Nov 7 2016, 7:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits