| • JKatzWMF | |
| Dec 10 2015, 9:26 PM |
| F3065922: cover.png | |
| Dec 10 2015, 9:26 PM |
from: nirzar
A small fix if we can do in the future for the thumbnails (see attachment)
If we use background-size:cover;
The layout looks much better, less odd white spaces on left side. i couldn't find if some browsers don't support that property.
Also it will reduce the overhead of figuring out portrait and landscape and one more class related to that.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use background-size:cover for thumbnails | mediawiki/extensions/Cards | dev | +3 -0 |
Here [1] is the compatibility table. Mobile browsers don't seem to support this feature well.
[1] https://developer.mozilla.org/en-US/docs/Web/CSS/background-size
Change 259193 had a related patch set uploaded (by Jhobs):
Use background-size:cover for thumbnails
Unless the image is square it'll be scaled up when using background-size: cover;. The image being requested is still 80px wide, and thus looks blurry when not a square (very often). You'll either have to query again once you have the image dimensions, or just request for a larger image and hope for the best.
If there a way to get image proportions without requesting the image data, then you're in luck .
@Jdlrobson Definitely. I will create another card for image quality with spec. we can sign off on this one meanwhile.