Page MenuHomePhabricator
Create Task
Maniphest T121638

VE GraphNode tests are failing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

SubjectRepoBranchLines +/-
Fix unit test dependenciesmediawiki/extensions/Graphmaster+2 -1
Customize query in gerrit

Event Timeline

Esanders created this task.Dec 16 2015, 2:04 PM
Esanders assigned this task to • ferdbold.
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, MediaWiki-extensions-Graph.
Esanders subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 16 2015, 2:04 PM
• ferdbold added a comment.Dec 17 2015, 5:57 PM

How is this possible? Doesn't jenkins run the tests before trying to merge?

Esanders added a comment.Dec 17 2015, 9:24 PM

I think the graph extension isn't part of the CI test build.

gerritbot subscribed.Dec 23 2015, 9:38 PM

Change 260863 had a related patch set uploaded (by Ferdbold):
Fix unit test dependencies

https://gerrit.wikimedia.org/r/260863

gerritbot added a project: Patch-For-Review.Dec 23 2015, 9:38 PM
• ferdbold moved this task from Backlog to VisualEditor on the MediaWiki-extensions-Graph board.Dec 23 2015, 9:39 PM
gerritbot added a comment.Dec 30 2015, 6:15 AM

Change 260863 merged by jenkins-bot:
Fix unit test dependencies

https://gerrit.wikimedia.org/r/260863

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 30 2015, 7:00 AM
• ferdbold closed this task as Resolved.Jan 2 2016, 8:14 PM
• ferdbold set Security to None.
Jdforrester-WMF triaged this task as High priority.Jan 3 2016, 7:45 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jan 13 2016, 4:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits