Page MenuHomePhabricator
Create Task
Maniphest T122090

ChangeTags::updateTags() should be able to derive log_id from rev_id (and the other way) when applicable
Closed, ResolvedPublic
Actions

Description

ChangeTags::updateTags() should be able to derive log_id from rev_id (and the other way) when applicable.

Details

SubjectRepoBranchLines +/-
ChangeTags: Teach updateTags() to derive log_id from rev_id (and the other way)mediawiki/coremaster+16 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Dec 21 2015, 10:17 PM
matmarex claimed this task.
matmarex raised the priority of this task from to Medium.
matmarex updated the task description. (Show Details)
matmarex added a project: MediaWiki-Change-tagging.
matmarex added subscribers: matmarex, TTO.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 21 2015, 10:17 PM
matmarex added a subtask: T122089: Log entries and associated page revisions are not actually associated in the database.Dec 21 2015, 10:18 PM
matmarex closed subtask T122089: Log entries and associated page revisions are not actually associated in the database as Resolved.Jan 7 2016, 2:34 AM
gerritbot subscribed.Jan 7 2016, 3:21 AM

Change 262858 had a related patch set uploaded (by Bartosz Dziewoński):
ChangeTags: Teach updateTags() to derive log_id from rev_id (and the other way)

https://gerrit.wikimedia.org/r/262858

gerritbot added a project: Patch-For-Review.Jan 7 2016, 3:21 AM
gerritbot added a comment.Jan 18 2016, 12:56 AM

Change 262858 merged by jenkins-bot:
ChangeTags: Teach updateTags() to derive log_id from rev_id (and the other way)

https://gerrit.wikimedia.org/r/262858

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 18 2016, 1:00 AM
matmarex closed this task as Resolved.Jan 18 2016, 5:04 PM

@TTO I really love how all the tag editing stuff you wrote is robust enough to handle this with no changes needed :D It all just worked, magic. I submitted a tiny follow-up change to the log formatter: https://gerrit.wikimedia.org/r/264759

matmarex added a parent task: T121874: Tagging file uploads with change tags is difficult bordering on impossible.Jan 18 2016, 11:28 PM
matmarex removed a parent task: T121874: Tagging file uploads with change tags is difficult bordering on impossible.
TTO added a comment.Jan 19 2016, 2:14 AM

Thanks Bartosz, I think it's just luck though :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL