Page MenuHomePhabricator
Create Task
Maniphest T122941

Qunit jobs consistently failing on all slaves
Closed, ResolvedPublic
Actions

Description

Upstream Issue: https://github.com/karma-runner/karma/issues/1782

mediawiki-core-qunit builds have been failing since #56634. This could be fixed with a downgrade I believe.

Console:

00:19:47 Running "karma:main" (karma) task
00:19:47 06 01 2016 00:19:47.138:INFO [karma]: Karma v0.13.10 server started at http://localhost:9876/
00:19:47 06 01 2016 00:19:47.167:INFO [launcher]: Starting browser Chrome
00:19:51 06 01 2016 00:19:51.718:INFO [Chromium 47.0.2526 (Ubuntu 0.0.0)]: Connected on socket /#e7Iz24mfR_FJ5dmQAAAA with id 6014961
00:20:01 ................................................................................
00:20:01 ................................................................................
00:20:05 ................................................................................
00:20:05 .................................................................
00:20:05 Chromium 47.0.2526 (Ubuntu 0.0.0): Executed 305 of 305 SUCCESS (7.557 secs / 7.238 secs)
00:20:05 Missing error handler on `socket`.
00:20:05 TypeError: Object [object Object] has no method 'forEach'
00:20:05     at disconnectBrowsers (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/lib/server.js:311:13)
00:20:05     at null.<anonymous> (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/lib/server.js:291:7)
00:20:05     at EventEmitter.emit (events.js:117:20)
00:20:05     at emitRunCompleteIfAllBrowsersDone (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/lib/server.js:256:12)
00:20:05     at null.<anonymous> (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/lib/server.js:278:9)
00:20:05     at EventEmitter.emit (events.js:117:20)
00:20:05     at onComplete (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/lib/browser.js:142:13)
00:20:05     at Socket.<anonymous> (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/lib/events.js:13:22)
00:20:05     at Socket.EventEmitter.emit (events.js:117:20)
00:20:05     at Socket.onevent (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/node_modules/socket.io/lib/socket.js:335:8)
00:20:05     at Socket.onpacket (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/node_modules/socket.io/lib/socket.js:295:12)
00:20:05     at Client.ondecoded (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/node_modules/socket.io/lib/client.js:193:14)
00:20:05     at Decoder.Emitter.emit (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/node_modules/socket.io/node_modules/socket.io-parser/node_modules/component-emitter/index.js:134:20)
00:20:05     at Decoder.add (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/node_modules/socket.io/node_modules/socket.io-parser/index.js:247:12)
00:20:05     at Client.ondata (/mnt/jenkins-workspace/workspace/mediawiki-core-qunit/src/node_modules/karma/node_modules/socket.io/lib/client.js:175:18)
00:20:05     at Socket.EventEmitter.emit (events.js:95:17)
00:21:05 06 01 2016 00:21:05.859:WARN [Chromium 47.0.2526 (Ubuntu 0.0.0)]: Disconnected (1 times), because no message in 60000 ms.
00:21:05 Chromium 47.0.2526 (Ubuntu 0.0.0): Executed 305 of 305 DISCONNECTED (1 min 7.573 secs / 7.238 secs)
00:21:05 Fatal error: Object [object Object] has no method 'forEach'
00:21:05 Build step 'Execute shell' marked build as failure
00:21:05 [PostBuildScript] - Execution post build scripts.

Details

SubjectRepoBranchLines +/-
Update karma to 0.13.19mediawiki/corewmf/1.27.0-wmf.9+1 -1
Update karma to 0.13.19mediawiki/coremaster+1 -1
Fix Qunit testsmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Unicornisaurous created this task.Jan 6 2016, 12:35 AM
Unicornisaurous raised the priority of this task from to High.
Unicornisaurous updated the task description. (Show Details)
Unicornisaurous added a project: Continuous-Integration-Infrastructure.
Unicornisaurous subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2016, 12:35 AM
Paladox subscribed.Jan 6 2016, 12:42 AM

socket.io was updated to 1.4.0 from 1.3.7. https://github.com/karma-runner/karma/issues/1782#issuecomment-169178567

Users have said even downgrading hasent worked either.

Unicornisaurous updated the task description. (Show Details)Jan 6 2016, 12:45 AM
Unicornisaurous set Security to None.
gerritbot subscribed.Jan 6 2016, 12:48 AM

Change 262684 had a related patch set uploaded (by Paladox):
Fix Qunit tests

https://gerrit.wikimedia.org/r/262684

gerritbot added a project: Patch-For-Review.Jan 6 2016, 12:48 AM
Paladox added a comment.Jan 6 2016, 12:54 AM

Users are reporting now that 0.13.9 is working.

Also the author of it has responded and has said a patch is incoming.

Paladox added a comment.Jan 6 2016, 12:55 AM

0.13.19 has been released now with the socket.io fix.

gerritbot added a comment.Jan 6 2016, 1:03 AM

Change 262686 had a related patch set uploaded (by Paladox):
Update karma to 0.13.19 fixes Bug: T122941

https://gerrit.wikimedia.org/r/262686

gerritbot added a comment.Jan 6 2016, 2:54 AM

Change 262686 merged by jenkins-bot:
Update karma to 0.13.19

https://gerrit.wikimedia.org/r/262686

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 6 2016, 3:00 AM
gerritbot added a comment.Jan 6 2016, 4:29 AM

Change 262684 abandoned by Krinkle:
Fix Qunit tests

Reason:
Obsolete per https://github.com/karma-runner/karma/issues/1782

https://gerrit.wikimedia.org/r/262684

Krinkle closed this task as Resolved.Jan 6 2016, 4:33 AM
Krinkle claimed this task.
Krinkle subscribed.

Fixed by 522e673e7e6a29232843250279f3a6c85d1af5fe.

Krinkle edited projects, added MediaWiki-Core-Tests; removed Continuous-Integration-Infrastructure.Jan 6 2016, 4:33 AM
gerritbot added a comment.Jan 14 2016, 12:26 AM

Change 264033 had a related patch set uploaded (by Krinkle):
Update karma to 0.13.19

https://gerrit.wikimedia.org/r/264033

gerritbot added a comment.Jan 14 2016, 12:27 AM

Change 264033 merged by Krinkle:
Update karma to 0.13.19

https://gerrit.wikimedia.org/r/264033

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Jan 14 2016, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL