Page MenuHomePhabricator
Create Task
Maniphest T124446

TypeError: Cannot set property 'text-decoration' of undefined
Closed, ResolvedPublic
Actions

Description

Just witnessed an exception thrown by the service in production:

[2016-01-22T18:12:07.293Z] ERROR: mobileapps/199 on scb1001: 500: internal_error (message="500: internal_error", status=500, type=internal_error, detail="Cannot set property 'text-decoration' of undefined", levelPath=error/500, request_id=9fb9654c-c133-11e5-996e-7cc00f987d3f)
    stack: TypeError: Cannot set property 'text-decoration' of undefined
        at Parser.<anonymous> (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:20:56)
        at Parser.EventTarget.fire (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/cssparser.js:91:30)
        at Parser.additions._declaration (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/cssparser.js:2615:26)
        at Parser.additions._readDeclarations (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/cssparser.js:3123:41)
        at Parser.additions.parseStyleAttribute (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/cssparser.js:3344:22)
        at parseStyles (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:23:10)
        at Object.create._parsed.get (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:36:28)
        at Object.create.getPropertyValue.value (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:87:16)
        at Object.defineProperty.get (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:258:19)
        at Object.hideIPA (/srv/deployment/mobileapps/deploy/src/lib/transformations/hideIPA.js:25:29)
        at runAllSectionsTransforms (/srv/deployment/mobileapps/deploy/src/lib/transforms.js:240:13)
        at Object.runParsoidDomTransforms (/srv/deployment/mobileapps/deploy/src/lib/transforms.js:261:5)
        at Request.<anonymous> (/srv/deployment/mobileapps/deploy/src/lib/parsoid-access.js:178:24)
        at Request.tryCatcher (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/util.js:11:23)
        at Promise._settlePromiseFromHandler (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:489:31)
        at Promise._settlePromise (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:546:18)

Looks like a problem in the domino library, but please investigate this.

Details

SubjectRepoBranchLines +/-
Update domino to 1.0.23mediawiki/services/mobileappsmaster+7 -1
Customize query in gerrit

Related Objects

Event Timeline

• mobrovac created this task.Jan 22 2016, 6:16 PM
• mobrovac raised the priority of this task from to High.
• mobrovac updated the task description. (Show Details)
• mobrovac added projects: Mobile-Content-Service, Services.
• mobrovac subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2016, 6:16 PM
• mobrovac updated the task description. (Show Details)Jan 22 2016, 6:21 PM
• mobrovac set Security to None.
• mobrovac edited subscribers, added: • Mholloway, • bearND; removed: Aklapper.
• Mholloway added a comment.EditedJan 25 2016, 4:10 PM

Opened an issue/PR on the Domino library:

https://github.com/fgnass/domino/issues/68
https://github.com/fgnass/domino/pull/69

• Mholloway renamed this task from Exception in production to TypeError: Cannot set property 'text-decoration' of undefined.Jan 25 2016, 4:10 PM
• Mholloway claimed this task.
• Mholloway moved this task from Incoming to Doing on the Mobile-Content-Service board.
• Mholloway moved this task from Doing to Tracking on the Mobile-Content-Service board.
• Mholloway added a project: Wikipedia-Android-App-Backlog.Jan 25 2016, 4:18 PM
• Mholloway moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.
• Mholloway moved this task from Bug Backlog to Open Questions/Discussions on the Wikipedia-Android-App-Backlog board.
• Mholloway moved this task from Open Questions/Discussions to Tracking on the Wikipedia-Android-App-Backlog board.
• Mholloway added a comment.Jan 28 2016, 4:46 PM

Deployed the domino update this morning, but reverted shortly thereafter because it created a flood of these in production:

TypeError: Cannot convert object to primitive value    
 at Object.create._serialize.value (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:55:23)
 at Object.create.setProperty.value (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:134:10)    
 at Object.defineProperty.set (/srv/deployment/mobileapps/deploy/node_modules/domino/lib/CSSStyleDeclaration.js:265:12)
 at Object.hideIPA (/srv/deployment/mobileapps/deploy/src/lib/transformations/hideIPA.js:45:34)
 at runAllSectionsTransforms (/srv/deployment/mobileapps/deploy/src/lib/transforms.js:242:13)
 at Object.runParsoidDomTransforms (/srv/deployment/mobileapps/deploy/src/lib/transforms.js:263:5)
 at Request.<anonymous> (/srv/deployment/mobileapps/deploy/src/lib/parsoid-access.js:181:24)
 at Request.tryCatcher (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/util.js:11:23)
 at Promise._settlePromiseFromHandler (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:491:31)    
 at Promise._settlePromise (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:548:18)
 at Promise._settlePromise0 (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:593:10)
 at Promise._settlePromises (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:676:18)
 at Promise._fulfill (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:617:18)
 at Promise._resolveCallback (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:418:57)
 at Promise._settlePromiseFromHandler (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:504:17)  
 at Promise._settlePromise (/srv/deployment/mobileapps/deploy/node_modules/bluebird/js/release/promise.js:548:18)
• Mholloway added a comment.Jan 28 2016, 4:53 PM

Filed https://github.com/fgnass/domino/issues/71.

• Mholloway moved this task from Tracking to Doing on the Mobile-Content-Service board.Feb 1 2016, 3:09 PM
gerritbot subscribed.Feb 1 2016, 3:28 PM

Change 267679 had a related patch set uploaded (by Mholloway):
Update domino to 1.0.23

https://gerrit.wikimedia.org/r/267679

gerritbot added a project: Patch-For-Review.Feb 1 2016, 3:28 PM
• Mholloway added a comment.Feb 1 2016, 3:31 PM

The fix for last Thursday's problem has been released in Domino 1.0.23. It should be deployed tomorrow during the coordinated deploy window along with our RESTBase URI change.

• Mholloway removed a project: Wikipedia-Android-App-Backlog.Feb 1 2016, 3:35 PM
gerritbot added a comment.Feb 1 2016, 6:58 PM

Change 267679 merged by Mobrovac:
Update domino to 1.0.23

https://gerrit.wikimedia.org/r/267679

• Mholloway moved this task from Doing to To Deploy on the Mobile-Content-Service board.Feb 2 2016, 8:40 PM
• Mholloway closed this task as Resolved.Feb 5 2016, 4:27 PM
• Mholloway mentioned this in T141833: 500 errors from feed endpoint.Aug 2 2016, 6:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL