Page MenuHomePhabricator

Onboarding for share-a-fact points to wrong icon since wiktionary icon added
Closed, ResolvedPublic

Description

Description
Onboarding for share-a-fact points to wrong icon and has overlay issue with highlight pointers

Steps to reproduce
Fresh install
Go to an article
Highlight text
Share-a-fact onboarding appears

Expected results
Pointer should point to share button and cover up highlight pointers

Actual results
Looks like this:

Screenshot_2016-01-26-13-51-23.png (2×1 px, 423 KB)

App version 2.1.139-alpha-2016-01-25

Event Timeline

KHammerstein raised the priority of this task from to Needs Triage.
KHammerstein updated the task description. (Show Details)
KHammerstein subscribed.
bearND triaged this task as Medium priority.
bearND moved this task from To Do to Doing on the Mobile-App-Android-Sprint-75-Rhenium board.

Change 270243 had a related patch set uploaded (by BearND):
Change order of text highlight CAB actions

https://gerrit.wikimedia.org/r/270243

@KHammerstein The simplest fix for pointing to the wrong location is to change the order of actions in the CAB. I moved the definition action to the end. Is this OK?

pasted_file (691×524 px, 118 KB)

Change 270243 merged by jenkins-bot:
Change order of text highlight CAB actions

https://gerrit.wikimedia.org/r/270243

@bearND Yes thats fine! I think thats a better order actually.

Onboarding for share-a-fact points to a correct icon now - checked with 2.1.141-alpha-2016-02-12 on Nexus 5 (Android 5.1.1)

Screenshot_2016-02-12-12-13-24.png (1×1 px, 607 KB)

Note:
Clean installation comes with A/B feature testing - readMoreSearchOpeningText enabled by default. Then, onboarding share a fact points between icons.

Screenshot_2016-02-12-12-06-44 (1).png (1×1 px, 336 KB)