Page MenuHomePhabricator
Create Task
Maniphest T125572

AbuseFilter: Cannot access property on non-object
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production:

Notice: Cannot access property on non-object in /srv/mediawiki/php-1.27.0-wmf.10/extensions/AbuseFilter/AbuseFilter.class.php on line 1842

Details

SubjectRepoBranchLines +/-
AbuseFilterViewEdit: Correctly reject non-existent historical versionsmediawiki/extensions/AbuseFiltermaster+5 -1
Customize query in gerrit

Event Timeline

• demon created this task.Feb 2 2016, 7:46 PM
• demon raised the priority of this task from to Medium.
• demon updated the task description. (Show Details)
• demon added projects: Wikimedia-production-error, AbuseFilter.
• demon subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2016, 7:46 PM
• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Mar 12 2016, 12:00 AM
matmarex claimed this task.Apr 2 2016, 10:10 PM
matmarex subscribed.

This happens for URLs like Special:AbuseFilter/history/<id>/item/<oldid>, where <id> is a valid filter id, but <oldid> is not a valid filter version id.

gerritbot subscribed.Apr 2 2016, 10:12 PM

Change 281235 had a related patch set uploaded (by Bartosz Dziewoński):
AbuseFilterViewEdit: Correctly reject non-existent historical versions

https://gerrit.wikimedia.org/r/281235

gerritbot added a project: Patch-For-Review.Apr 2 2016, 10:12 PM
gerritbot added a comment.Apr 2 2016, 10:25 PM

Change 281235 merged by jenkins-bot:
AbuseFilterViewEdit: Correctly reject non-existent historical versions

https://gerrit.wikimedia.org/r/281235

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Apr 2 2016, 11:00 PM
matmarex closed this task as Resolved.Apr 2 2016, 11:25 PM
matmarex removed a project: Patch-For-Review.
• demon moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 10 2016, 8:44 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits