Page MenuHomePhabricator

Unclosed <noinclude> tags no longer work (wmf.12 regression)
Closed, ResolvedPublic

Description

[11:17:07] <legoktm> did something change in the parser in wmf.12?
[11:17:17] <legoktm> https://en.wiktionary.org/wiki/apps now displays <noinclude> tags
[11:17:46] <legoktm> https://en.wiktionary.org/w/index.php?title=Template:plural_of&action=edit has an unclosed <noinclude> tag, but it definitely used to work
[11:19:12] <Krenair> yeah that changed
[11:19:23] <Krenair> https://gerrit.wikimedia.org/r/#/c/255258/
[11:19:47] <Krenair> wmf.12 change
[11:21:42] <legoktm> MatmaRex: ^^
[11:22:10] <legoktm> > * Should we keep previous behavior for unclosed <includeonly> / <noinclude>? This would be particularly disruptive for these if someone relied on the old behavior, and they're already special-cased in places.
[11:22:15] <legoktm> yeah.... :P
[11:22:28] <MatmaRex> hm
[11:22:36] <MatmaRex> yes
[11:22:42] <MatmaRex> how bad is it? :P
[11:23:25] <greg-g> wmf.12 is on group0 and group1, fwiw
[11:24:59] <legoktm> MatmaRex: https://en.wiktionary.org/wiki/Wiktionary:Grease_pit#Project_link_template_mess
[11:25:18] <legoktm> it's also breaking templates on commons apparently
[11:26:22] <Krenair> can you put together a quick fix to backport, or should this change be reverted out of wmf.12?
[11:28:06] <MatmaRex> uhh, i probably can
[11:28:32] <legoktm> should I file a bug about this?
[11:28:39] <MatmaRex> but do we want to do it this way? if it's breaking too many things, go ahead and revert
[11:29:40] <Krenair> legoktm, yes, I think so
[11:30:03] <MatmaRex> barack obama, for one, looks fine. so it might be just a few broken templates.
[11:30:18] <MatmaRex> commons' main page seems rekt, but i probably don't have permissions to fix it…

See #wikimedia-tech for more.

Event Timeline

Legoktm assigned this task to matmarex.
Legoktm raised the priority of this task from to Unbreak Now!.
Legoktm updated the task description. (Show Details)
Legoktm added subscribers: Legoktm, Krenair.
Legoktm renamed this task from Unclosed <noinclude> tags no longer work (wmf.12 regression_ to Unclosed <noinclude> tags no longer work (wmf.12 regression).Feb 4 2016, 12:31 AM
Legoktm set Security to None.

Change 268331 had a related patch set uploaded (by Legoktm):
Revert "Preprocessor: Don't allow unclosed extension tags (matching until end of input)"

https://gerrit.wikimedia.org/r/268331

Change 268332 had a related patch set uploaded (by Legoktm):
Revert "Preprocessor: Don't allow unclosed extension tags (matching until end of input)"

https://gerrit.wikimedia.org/r/268332

Change 268332 merged by jenkins-bot:
Revert "Preprocessor: Don't allow unclosed extension tags (matching until end of input)"

https://gerrit.wikimedia.org/r/268332

reverted on master and wmf.12 branches

Change 268331 merged by Bartosz Dziewoński:
Revert "Preprocessor: Don't allow unclosed extension tags (matching until end of input)"

https://gerrit.wikimedia.org/r/268331