Page MenuHomePhabricator
Create Task
Maniphest T126102

[Dev] Upgrade MapBox to v3.2.0+
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Description

The MapBox dependency should be upgraded from v2.3.0 to the latest, v3.2.0.

https://github.com/mapbox/mapbox-gl-native/releases

Details

SubjectRepoBranchLines +/-
Update Mapbox to 4.0.0apps/android/wikipediamaster+136 -245
Customize query in gerrit

Event Timeline

• Niedzielski created this task.Feb 6 2016, 2:16 AM
• Niedzielski raised the priority of this task from to Lowest.
• Niedzielski updated the task description. (Show Details)
• Niedzielski added a project: Wikipedia-Android-App-Backlog.
• Niedzielski subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2016, 2:16 AM
Dbrant moved this task from Needs Triage to Next Sprint on the Wikipedia-Android-App-Backlog board.Feb 8 2016, 3:28 PM
Dbrant subscribed.Feb 12 2016, 9:13 PM

note: check for arm64 libs!

MBinder_WMF set Security to None.Feb 12 2016, 9:15 PM
MBinder_WMF edited a custom field.
Dbrant added a project: Mobile-App-Android-Sprint-76-Osmium.Feb 15 2016, 5:15 PM
Dbrant moved this task from Next Sprint to Current Sprint on the Wikipedia-Android-App-Backlog board.Feb 15 2016, 5:15 PM
Dbrant claimed this task.Feb 16 2016, 5:39 PM
Dbrant moved this task from To Do to Doing on the Mobile-App-Android-Sprint-76-Osmium board.
gerritbot subscribed.Feb 16 2016, 6:02 PM

Change 271007 had a related patch set uploaded (by Dbrant):
Update Mapbox to 3.2.0

https://gerrit.wikimedia.org/r/271007

gerritbot added a project: Patch-For-Review.Feb 16 2016, 6:02 PM
Dbrant changed the task status from Open to Stalled.Feb 16 2016, 7:14 PM

Stalling, pending a blocking issue in Mapbox:
https://github.com/mapbox/mapbox-gl-native/issues/3631

Dbrant removed a project: Mobile-App-Android-Sprint-76-Osmium.Feb 16 2016, 7:14 PM
Dbrant moved this task from Current Sprint to Tracking on the Wikipedia-Android-App-Backlog board.
• Niedzielski added a comment.Mar 17 2016, 11:21 PM

And here's that ABI issue (slated for 4.0!): https://github.com/mapbox/mapbox-gl-native/issues/3128

Dbrant closed this task as Resolved.Apr 11 2016, 2:04 PM
Dbrant reopened this task as Open.
Dbrant added a project: Mobile-App-Android-Sprint-80-Mercury.
Dbrant moved this task from To Do to Did Not Pass QA on the Mobile-App-Android-Sprint-80-Mercury board.
Dbrant moved this task from Did Not Pass QA to QA Signoff on the Mobile-App-Android-Sprint-80-Mercury board.

[mouse dragging fail]

gerritbot added a comment.Apr 11 2016, 2:19 PM

Change 271007 merged by jenkins-bot:
Update Mapbox to 4.0.0

https://gerrit.wikimedia.org/r/271007

Dbrant added a comment.Apr 11 2016, 5:02 PM

QA: no functional changes expected.

• Niedzielski added a comment.Apr 11 2016, 5:03 PM

Please check that Nearby no longer crashes on your Galaxy Tab S4. Thanks!

Nicholas.tsg subscribed.Apr 12 2016, 10:06 PM

Testing Samsung Galaxy with Android 4.4.2 and Wikipedia app build 2.1.143-alpha-2016-04-12. "Nearby" doesn't crash, although instead of showing locations specifically in San Francisco (my testing location) it is showing a map of the world such as Africa and the Atlantic Ocean as my "Nearby" locations. I'm still moving this to the "Ready for Signoff" (fixed) column based on the "no crashing" rule.

Nicholas.tsg moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Android-Sprint-80-Mercury board.Apr 12 2016, 10:07 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Android-Sprint-80-Mercury board.Apr 14 2016, 7:14 PM
Dbrant closed this task as Resolved.Apr 14 2016, 7:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits