Page MenuHomePhabricator
Create Task
Maniphest T126129

abusefilter-view-private should let you view histories of private filters
Closed, ResolvedPublic
Actions

Description

Report (second thread).

Apparently users in the abusefilter-helper group can't see histories of filters tagged as private, despite being able already to view abuse filters marked as private and abuse filter log entries of private filters as well. Users with the abusefilter-view-private should be able to see Special:AbuseFilter/history/xxx entries as well.

Details

SubjectRepoBranchLines +/-
Allow users with 'abusefilter-view-private' to view history/diff of private filtersmediawiki/extensions/AbuseFiltermaster+7 -7
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Feb 6 2016, 7:26 PM
MarcoAurelio raised the priority of this task from to Medium.
MarcoAurelio updated the task description. (Show Details)
MarcoAurelio added a project: AbuseFilter.
MarcoAurelio added subscribers: MarcoAurelio, MusikAnimal.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2016, 7:26 PM
MarcoAurelio added a project: Stewards-and-global-tools.Apr 26 2016, 10:15 AM
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptApr 26 2016, 10:15 AM
gerritbot subscribed.Apr 26 2016, 4:18 PM

Change 285422 had a related patch set uploaded (by Glaisher):
Allow users with 'abusefilter-view-private' to view history/diff of private filters

https://gerrit.wikimedia.org/r/285422

gerritbot added a project: Patch-For-Review.Apr 26 2016, 4:18 PM
MarcoAurelio added a comment.Jul 25 2016, 10:06 AM

Can the above patch be tested and deployed if it works? Thanks!

gerritbot added a comment.Aug 11 2016, 1:43 AM

Change 285422 merged by jenkins-bot:
Allow users with 'abusefilter-view-private' to view history/diff of private filters

https://gerrit.wikimedia.org/r/285422

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 11 2016, 2:00 AM
Glaisher closed this task as Resolved.Aug 11 2016, 4:27 AM
Glaisher claimed this task.
Orlodrim mentioned this in T143365: abusefilter-modify should let you view histories of private filters.Aug 18 2016, 9:16 PM
• DannyH moved this task from Untriaged to Closed on the Stewards-and-global-tools board.Sep 19 2016, 8:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits