Page MenuHomePhabricator

Send correct event logging languageButtonTappedBucket value when client LocalStorage capable and first use of switcher
Closed, ResolvedPublic

Description

As a product owner, I would like bucketed event logged language switcher use to reflect correctly, for LocalStorage capable devices, a languageButtonTappedBucket value of 0 taps if it's the first time the user accessed the language switcher....so that my query results are even more precise. As has been the case, for devices that do not support LocalStorage, I would still like for the value languageButtonTappedBucket to be sent as `unknown', though.

As mentioned in T125127#2024286 there appears to be a small bug in https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/b844b109e165e9e73d467b2575d489ec08df7f8f/resources/skins.minerva.scripts/init.js#L114 whereby a client that technically supports LocalStorage is sending a languageButtonTappedBucket value of unknown instead of 0 taps.

Event Timeline

dr0ptp4kt raised the priority of this task from to Normal.
dr0ptp4kt updated the task description. (Show Details)
dr0ptp4kt added a subscriber: dr0ptp4kt.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2016, 10:31 PM

Change 270779 had a related patch set uploaded (by Bmansurov):
Send correct event logging languageButtonTappedBucket value

https://gerrit.wikimedia.org/r/270779

Change 270779 merged by jenkins-bot:
Send correct event logging languageButtonTappedBucket value

https://gerrit.wikimedia.org/r/270779

Jdlrobson set Security to None.

Which URL should be tested?

dr0ptp4kt closed this task as Resolved.Feb 18 2016, 2:36 PM
dr0ptp4kt added a subscriber: bmansurov.