Page MenuHomePhabricator

Special:GraphSandbox should use CSS instead of obsolete width attribute
Closed, ResolvedPublic

Event Timeline

He7d3r created this task.Feb 15 2016, 11:35 AM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added a subscriber: He7d3r.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 15 2016, 11:35 AM
Yurik added a subscriber: Yurik.Feb 15 2016, 1:03 PM

@He7d3r I know graph sandbox needs some polishing, but I'm pretty bad with the html/css layouts. Any help is welcome :)

@He7d3r, I have never worked with the Graph extension but let me submit a patch for this :)

D3r1ck01 claimed this task.Feb 15 2016, 2:00 PM
D3r1ck01 set Security to None.

Change 270733 had a related patch set uploaded (by D3r1ck01):
Removing obsolete html Width attribute

https://gerrit.wikimedia.org/r/270733

Yurik added a comment.Feb 15 2016, 2:47 PM

Thanks, I will test it in an hour. How hard would it be to make it so that there are no multiple nested scrollbars ? And also so that smaller screens still show it reasonably well?

Change 270733 merged by jenkins-bot:
Removing obsolete html Width attribute

https://gerrit.wikimedia.org/r/270733

Danny_B moved this task from Unsorted to Needs refactor on the Technical-Debt board.
Danny_B moved this task from Unsorted to Inline / obtrusive code on the Accessibility board.

@Danny_B, do you want this who extension to be refactored?

@Danny_B, do you want this who extension to be refactored?

Such column is for any kind of refactoring, even small like this task. It does not imply any particular size of work.

Yurik added a comment.Feb 15 2016, 6:31 PM

Should this task be closed and a new one created for improving the sandbox usability? Currently when edit box has a lot of text, it shows two sets of the scrollbars - one for the editor's container, and another for the editor itself.

D3r1ck01 added a comment.EditedFeb 15 2016, 6:34 PM

@Danny_B, i buy @Yurik's idea, i think creating another task which will be purposely to improve on the usability of Sandbox will be a good thing to do. This task can be marked as resolved. What do you think?

If this is solved, just close it. If you found another issue not covered by this task, please open new.

The columns in Technical-Debt workboard is purely about tasks they contain, not about the entire product. Thus since this task is about refactoring the formatting a bit, it went to the Rewrite / Refactor column...

Yurik closed this task as Resolved.Feb 15 2016, 6:40 PM

Created new task T127010