Page MenuHomePhabricator
Create Task
Maniphest T128053

ApiSandbox incorrectly converts spaces from URL parameters
Closed, ResolvedPublic
Actions

Description

It seems to only convert the first one; someone missed a g flag somewhere?

Steps to reproduce:

  1. Visit this URL
  2. Press make request, and notice that the request succeeds. Note that spaces in the titles parameter in the URL have been correctly converted to pluses
  3. Reload the page, press make request again, and notice that the request fails due to all but the first plus not being converted back to a space.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ApiSandbox: Convert all pluses in URL to spaces, not just the first oneMajrmediawiki/coremaster+1 -1
ApiSandbox: Fix String.replace callAnomiemediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Majr created this task.Feb 25 2016, 6:19 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 25 2016, 6:19 AM
Majr claimed this task.Feb 25 2016, 7:08 AM
gerritbot subscribed.Feb 25 2016, 1:02 PM

Change 273208 had a related patch set uploaded (by Anomie):
ApiSandbox: Fix String.replace call

https://gerrit.wikimedia.org/r/273208

gerritbot added a project: Patch-For-Review.Feb 25 2016, 1:02 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Feb 25 2016, 1:03 PM
Majr added a comment.Feb 25 2016, 1:15 PM

I already submitted a patch for this when I claimed it, but the bot obviously ignored it for some reason...

https://gerrit.wikimedia.org/r/#/c/273186/

gerritbot added a comment.Feb 25 2016, 1:28 PM

Change 273186 had a related patch set uploaded (by Anomie):
ApiSandbox: Convert all pluses in URL to spaces, not just the first one

https://gerrit.wikimedia.org/r/273186

gerritbot added a comment.Feb 25 2016, 1:29 PM

Change 273208 abandoned by Anomie:
ApiSandbox: Fix String.replace call

Reason:
I45607c already exists.

https://gerrit.wikimedia.org/r/273208

Anomie subscribed.Feb 25 2016, 1:30 PM
In T128053#2063085, @Majr wrote:

I already submitted a patch for this when I claimed it, but the bot obviously ignored it for some reason...

The footer is "Bug:", not "Task:". You can see the bot picked it up when I adjusted that (and misattributed it to me since it goes by "uploader" rather than "author").

gerritbot added a comment.Feb 25 2016, 1:46 PM

Change 273186 merged by jenkins-bot:
ApiSandbox: Convert all pluses in URL to spaces, not just the first one

https://gerrit.wikimedia.org/r/273186

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 25 2016, 2:00 PM
Anomie closed this task as Resolved.Feb 25 2016, 3:14 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits