Page MenuHomePhabricator

Citation Bot not logged in when trying to do auto-expansion
Closed, ResolvedPublic5 Estimated Story Points

Description

See bug report at https://en.wikipedia.org/wiki/User_talk:Citation_bot#Bot_has_been_logged_out.

From the talk page:

Or it could be that the bot isn't properly handling cookies: it copies the Set-Cookie headers from the initial call to action=login (without correctly handling deleted cookies), then it manually constructs cookies from the deprecated response values which are likely to be failing to be valid anymore with the increased validation of the session data. Anomie⚔ 01:14, 20 February 2016 (UTC)

The bot should be updated to use proper log-in procedures.

Code lives at https://github.com/ms609/citation-bot.

Event Timeline

Bug can be reproduced by clicking "Expand citations" in the sidebar at https://en.wikipedia.org/wiki/Super_Star_Wars.

DannyH triaged this task as High priority.
DannyH set the point value for this task to 5.
DannyH moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
kaldari added a subscriber: Fhocutt.

Could the tasks "Relogging the bot" and "update to use an appropriate PHP MediaWiki API client library"be split in to different tasks, so that the bot could be relogged and be used in the meantime...or isn't it that simple?

Current login function lives at expandFns.php: logIn().

@Josve05a: Submitted a pull request: https://github.com/ms609/citation-bot/pull/106

Now we just have to hope that Martin is still around to merge and deploy it.

@Josve05a: Submitted a pull request: https://github.com/ms609/citation-bot/pull/106

Now we just have to hope that Martin is still around to merge and deploy it.

He merged it. Any way we can get the bot operational again?

@Josve05a: He merged it, but hasn't actually updated the code on Tool Labs. I'll see if I can track down one of the project maintainers to run git pull.

Fixed now and the gadget has been updated.