Maniphest T129468

Remove MobileFrontend implementation of isElementInViewport in favor of mw.viewport
Closed, ResolvedPublic
Actions

Description

When it actually works. See blocking task T129466 before merging this one.

Details

	Subject	Repo	Branch	Lines +/-
	Remove util.isElementInViewport in favor of mw.viewport	mediawiki/extensions/MobileFrontend	master	+5 -36

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T129468 Remove MobileFrontend implementation of isElementInViewport in favor of mw.viewport
		Resolved		• Jhernandez	T129466 mw.viewport.isElementInViewport broken when page scrolled

Event Timeline

• Jhernandez created this task.Mar 10 2016, 12:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2016, 12:01 PM

• Jhernandez added a subtask: T129466: mw.viewport.isElementInViewport broken when page scrolled.Mar 10 2016, 12:01 PM

Change 276442 had a related patch set uploaded (by Jhernandez):
Remove util.isElementInViewport in favor of mw.viewport

https://gerrit.wikimedia.org/r/276442

gerritbot added a project: Patch-For-Review.Mar 10 2016, 12:06 PM

• Jhernandez updated the task description. (Show Details)Mar 10 2016, 12:08 PM

• Jhernandez mentioned this in T126591: Refreshing page with lazy loading images enabled causes images to not load *on load*..Mar 10 2016, 12:14 PM

• jhobs triaged this task as High priority.Mar 10 2016, 6:07 PM

• jhobs added a project: Reading-Web-Sprint-67-If, Then, Else...?.

Change 276442 merged by jenkins-bot:
Remove util.isElementInViewport in favor of mw.viewport

https://gerrit.wikimedia.org/r/276442

Jdlrobson closed this task as Resolved.Mar 10 2016, 7:52 PM

Jdlrobson claimed this task.

Jdlrobson closed subtask T129466: mw.viewport.isElementInViewport broken when page scrolled as Resolved.

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-67-If, Then, Else...? board.

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-67-If, Then, Else...? board.

Danny_B moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Mar 11 2016, 6:39 AM

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 14 2016, 4:01 PM

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)).Mar 14 2016, 10:02 PM