Page MenuHomePhabricator
Create Task
Maniphest T129629

Wikitext conversion not working in Chrome/Windows when the source uses definition list formatting
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go here: http://trove.nla.gov.au/newspaper/article/147502721
  1. Click the (i) information icon in the upper left to get "Details". Scroll to the bottom of this pane and copy the wikitext citation. (Important to use this source!)
  1. Cite > Manual > Basic
  1. Paste in the wikitext.
  1. Save the page.
  1. See the nowiki tags.

Reported in Chrome version 49.0.2623.87 m and not reproducible in either Safari or Firefox on Mac. It's also not readily reproducible if you copy the wikitext out of a text file/off Wikipedia – you need to copy the citation template directly from the Trove website.

The Trove website uses HTML definition lists for this information. Pasting any text from a definition list in Chrome causes the same problem (e.g., copying the exposed wikitext in https://en.wikipedia.org/w/index.php?oldid=709594606#Definitions ).

Details

SubjectRepoBranchLines +/-
ElementLinearData: Include all non-content nodes is isPlainText loose modeVisualEditor/VisualEditormaster+7 -5
Customize query in gerrit

Event Timeline

• Whatamidoing-WMF created this task.Mar 11 2016, 5:49 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 11 2016, 5:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Whatamidoing-WMF updated the task description. (Show Details)Mar 11 2016, 5:56 AM
• Whatamidoing-WMF added a comment.Mar 11 2016, 7:01 AM

Two comments:

  • The Trove website uses HTML definition list formatting to display the multiple citation formats.
  • It's not necessary to paste it into the citation dialog. You can get the same lack-of-wikitext-conversion if you paste it into the body of an article.
Esanders subscribed.Mar 11 2016, 1:49 PM

Wikitext conversion only runs on plain text paste at the moment.

• Whatamidoing-WMF renamed this task from Wikitext conversion not working in Chrome/Windows, at least for basic refs to Wikitext conversion not always working in Chrome/Windows, maybe related to list formatting in the source.Mar 11 2016, 6:12 PM

So when I copy the same letters off the Trove website in Safari and Firefox, that's "plain text", but when Kerry copies exactly the same letters off the Trove website in Chrome, it's "rich text"?

• Whatamidoing-WMF renamed this task from Wikitext conversion not always working in Chrome/Windows, maybe related to list formatting in the source to Wikitext conversion not working in Chrome/Windows when the source uses definition list formatting.Mar 11 2016, 11:18 PM
• Whatamidoing-WMF updated the task description. (Show Details)

The problem seems to be related to definition/association list formatting.

Esanders added a comment.Mar 16 2016, 1:30 PM

The browser decides when you copy whether it's plain text or HTML. Firefox appears to be deciding it's plain text.

gerritbot subscribed.Mar 17 2016, 1:53 PM

Change 277765 had a related patch set uploaded (by Jforrester):
ElementLinearData: Include all non-content nodes is isPlainText loose mode

https://gerrit.wikimedia.org/r/277765

gerritbot added a project: Patch-For-Review.Mar 17 2016, 1:53 PM
gerritbot added a comment.Mar 17 2016, 2:02 PM

Change 277765 merged by jenkins-bot:
ElementLinearData: Include all non-content nodes is isPlainText loose mode

https://gerrit.wikimedia.org/r/277765

Jdforrester-WMF closed this task as Resolved.Mar 17 2016, 5:47 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)); removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Mar 23 2016, 7:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits