Page MenuHomePhabricator
Create Task
Maniphest T132362

HTMLHorizontalRuleFieldTest::testCreatingFieldGivesExpectedStrings test failure
Closed, ResolvedPublic
Actions

Description

This test is failing blocking merges in the RelatedPages module
e.g. https://integration.wikimedia.org/ci/job/mwext-testextension-php55/7505/console
see also https://gerrit.wikimedia.org/r/#/c/282196/

Details

SubjectRepoBranchLines +/-
Fix a failing testmediawiki/extensions/BetaFeaturesmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Apr 11 2016, 5:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2016, 5:02 PM
Jdlrobson added a parent task: T123549: Blurry image thumbnails accompany article suggestions.Apr 11 2016, 5:03 PM
Jdlrobson renamed this task from HTMLHorizontalRuleFieldTest::testCreatingFieldGivesExpectedStrings to HTMLHorizontalRuleFieldTest::testCreatingFieldGivesExpectedStrings test failure.Apr 11 2016, 5:15 PM
Jdlrobson added a parent task: T124317: upstream the isElementInViewport function.Apr 11 2016, 5:44 PM
• bmansurov updated the task description. (Show Details)Apr 11 2016, 6:23 PM
gerritbot subscribed.Apr 11 2016, 6:33 PM

Change 282741 had a related patch set uploaded (by Bmansurov):
Fix a failing test

https://gerrit.wikimedia.org/r/282741

gerritbot added a project: Patch-For-Review.Apr 11 2016, 6:33 PM
Jdlrobson added a project: Reading-Web-Sprint-70-Lady-and-the-Trumps.Apr 11 2016, 7:06 PM

I've pulled this into current sprint since it's blocking us from getting things already in the sprint done.

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 11 2016, 7:06 PM
gerritbot added a comment.Apr 11 2016, 9:22 PM

Change 282741 merged by jenkins-bot:
Fix a failing test

https://gerrit.wikimedia.org/r/282741

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 11 2016, 9:46 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 11 2016, 10:00 PM
• bmansurov closed this task as Resolved.Apr 11 2016, 10:43 PM
• bmansurov claimed this task.
• bmansurov moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.
phuedx subscribed.Apr 12 2016, 9:01 AM
In T132362#2196405, @Jdlrobson wrote:

I've pulled this into current sprint since it's blocking us from getting things already in the sprint done.

For posterity, this issue stopped cfc73ff from being merged, which is why this was brought into the sprint.

• bmansurov removed • bmansurov as the assignee of this task.Apr 12 2016, 12:15 PM
• bmansurov subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL