Page MenuHomePhabricator
Create Task
Maniphest T132411

UTSysop is not a sysop
Closed, ResolvedPublic
Actions

Description

Quoting https://gerrit.wikimedia.org/r/#/c/282735/,

Iec4ed4c8 made it so addCoreDBData() only gets called once. Which is
nice, except for the fact that it means any test that puts
'user_groups' into $this->tablesUsed is going to cause UTSysop to no
longer be a sysop, so any later test that expects it to be one is going
to mysteriously fail.

Fix is blocked by some tests (GatherTests, ApiEchoNotificationsTest, EchoDiscussionParserTest) relying on this (or at least on user tables not being cleaned up properly between tests).

Details

SubjectRepoBranchLines +/-
Use $tablesUsed rather than manually deleting all rows from the 'user' tablemediawiki/extensions/AntiSpoofREL1_27+2 -8
Use $tablesUsed rather than manually deleting all rows from the 'user' tablemediawiki/extensions/AntiSpoofmaster+2 -8
Fix core DB data in unit testingmediawiki/coremaster+23 -8
Reset Gather tables between testsmediawiki/extensions/Gathermaster+10 -0
Recreate test users for every testmediawiki/extensions/Echomaster+3 -8
Add StubAuthPluginmediawiki/coremaster+17 -1
Recreate test users after every testmediawiki/extensions/Gathermaster+12 -14
Customize query in gerrit

Event Timeline

Tgr created this task.Apr 11 2016, 11:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2016, 11:03 PM
gerritbot subscribed.Apr 11 2016, 11:05 PM

Change 282735 had a related patch set uploaded (by Gergő Tisza):
Fix core DB data in unit testing

https://gerrit.wikimedia.org/r/282735

gerritbot added a project: Patch-For-Review.Apr 11 2016, 11:05 PM
Anomie subscribed.Apr 12 2016, 1:16 PM
gerritbot added a comment.Apr 12 2016, 2:23 PM

Change 282940 had a related patch set uploaded (by Gergő Tisza):
Recreate test users after every test

https://gerrit.wikimedia.org/r/282940

gerritbot added a comment.Apr 12 2016, 2:41 PM

Change 282940 merged by jenkins-bot:
Recreate test users after every test

https://gerrit.wikimedia.org/r/282940

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 12 2016, 3:00 PM
gerritbot added a comment.Apr 12 2016, 3:43 PM

Change 282954 had a related patch set uploaded (by Anomie):
Recreate test users for every test

https://gerrit.wikimedia.org/r/282954

gerritbot added a comment.Apr 12 2016, 3:51 PM

Change 282953 abandoned by Gergő Tisza:
Add StubAuthPlugin

Reason:
Fixed differently in https://gerrit.wikimedia.org/r/#/c/282735/5/tests/phpunit/includes/api/ApiTestCase.php

https://gerrit.wikimedia.org/r/282953

gerritbot added a comment.Apr 12 2016, 4:05 PM

Change 282956 had a related patch set uploaded (by Gergő Tisza):
Reset Gather tables between tests

https://gerrit.wikimedia.org/r/282956

gerritbot added a comment.Apr 12 2016, 5:19 PM

Change 282954 merged by jenkins-bot:
Recreate test users for every test

https://gerrit.wikimedia.org/r/282954

gerritbot added a comment.Apr 12 2016, 5:26 PM

Change 282956 merged by jenkins-bot:
Reset Gather tables between tests

https://gerrit.wikimedia.org/r/282956

gerritbot added a comment.Apr 12 2016, 5:26 PM

Change 282735 merged by jenkins-bot:
Fix core DB data in unit testing

https://gerrit.wikimedia.org/r/282735

Anomie closed this task as Resolved.Apr 12 2016, 5:40 PM
Anomie claimed this task.
ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)).Apr 12 2016, 6:00 PM
Tgr reopened this task as Open.May 27 2016, 5:07 PM

This is happening again:

16:51:34 There were 3 failures:
16:51:34 
16:51:34 1) AntiSpoofPreAuthenticationProviderTest::testGetAuthenticationRequests with data set #4 ('create', array(true), 'UTSysop', array(AntiSpoofAuthenticationRequest Object (...)))
16:51:34 Failed asserting that two arrays are equal.
16:51:34 --- Expected
16:51:34 +++ Actual
16:51:34 @@ @@
16:51:34  Array (
16:51:34 -    0 => AntiSpoofAuthenticationRequest Object (...)
16:51:34  )
16:51:34 
16:51:34 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/AntiSpoof/tests/AntiSpoofPreAuthenticationProviderTest.php:26
16:51:34 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:390
16:51:34 
16:51:34 2) AntiSpoofPreAuthenticationProviderTest::testTestForAccountCreation with data set "illegal, sysop skipping" (true, false, array(), User Object (...), array(AntiSpoofAuthenticationRequest Object (...)), null)
16:51:34 Failed asserting that false is true.
16:51:34 
16:51:34 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/AntiSpoof/tests/AntiSpoofPreAuthenticationProviderTest.php:68
16:51:34 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:390
16:51:34 
16:51:34 3) AntiSpoofPreAuthenticationProviderTest::testTestForAccountCreation with data set "conflicts w/ skipping" (true, true, array('x'), User Object (...), array(AntiSpoofAuthenticationRequest Object (...)), null)
16:51:34 Failed asserting that false is true.
16:51:34 
16:51:34 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/AntiSpoof/tests/AntiSpoofPreAuthenticationProviderTest.php:68
16:51:34 /mnt/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:390
gerritbot added a comment.May 27 2016, 6:33 PM

Change 291298 had a related patch set uploaded (by Anomie):
[DO NOT MERGE] Testing for T132411

https://gerrit.wikimedia.org/r/291298

gerritbot added a comment.May 27 2016, 6:56 PM

Change 291309 had a related patch set uploaded (by Anomie):
Use $tablesUsed rather than manually deleting all rows from the 'user' table

https://gerrit.wikimedia.org/r/291309

gerritbot added a comment.May 27 2016, 7:19 PM

Change 291309 merged by jenkins-bot:
Use $tablesUsed rather than manually deleting all rows from the 'user' table

https://gerrit.wikimedia.org/r/291309

Anomie closed this task as Resolved.May 27 2016, 7:30 PM

https://gerrit.wikimedia.org/r/#/c/288902/ PS4 seems to indicate this is fixed now.

gerritbot added a comment.May 27 2016, 7:30 PM

Change 291298 abandoned by Anomie:
[DO NOT MERGE] Testing for T132411

Reason:
Done with the testing, it worked well.

https://gerrit.wikimedia.org/r/291298

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).Jun 1 2016, 12:01 AM
gerritbot added a comment.Jun 10 2016, 6:42 PM

Change 293786 had a related patch set uploaded (by Gergő Tisza):
Use $tablesUsed rather than manually deleting all rows from the 'user' table

https://gerrit.wikimedia.org/r/293786

gerritbot added a comment.Jun 10 2016, 6:45 PM

Change 293786 merged by jenkins-bot:
Use $tablesUsed rather than manually deleting all rows from the 'user' table

https://gerrit.wikimedia.org/r/293786

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL