Page MenuHomePhabricator
Create Task
Maniphest T132855

Unable to login to X!'s Tools
Closed, ResolvedPublic
Actions

Description

If I open
https://tools.wmflabs.org/xtools-articleinfo/
and then click on "Log In" which points to
https://tools.wmflabs.org/xtools/oauthredirector.php?action=login&callto=https://www.mediawiki.org/w/api.php&returnto=https://tools.wmflabs.org/xtools-articleinfo/
I'm redirected to something like
https://www.mediawiki.org/w/index.php?title=Special:OAuth/authorize&oauth_token=....&oauth_consumer_key=...
where I can click "Allow". At this point I get

Failed to initiate Authorization!
Returned error:
Error retrieving token: mwoauth-oauth-exception

Related Objects

Event Timeline

He7d3r created this task.Apr 16 2016, 5:19 PM
Restricted Application added subscribers: Matthewrbowker, Aklapper. · View Herald TranscriptApr 16 2016, 5:19 PM
• MZMcBride subscribed.Apr 16 2016, 9:59 PM
Matthewrbowker claimed this task.May 31 2016, 7:38 PM
Matthewrbowker triaged this task as High priority.
Matthewrbowker closed this task as Resolved.Jul 28 2016, 4:39 AM

I can't reproduce the error. If you see it again, feel free to re-open this task with more information.`

He7d3r reopened this task as Open.Jul 28 2016, 9:50 PM

It is still happening, but I needed to click on the link a second time (because at first nothing changed after clicking allow: i.e. I was not logged in apparently).

Matthewrbowker added a comment.Jul 28 2016, 9:52 PM

Ah. I can explain that.

When we authorize oauth, we authorize it for "http://tools.wmflabs.org/xtools" This is due to the way that OAuth is configured. Therefore, the authorization doesn't exist for xtools-articleinfo. The second attempt is seen my MediaWiki as a repeat action, and is disallowed.

We are working to move everything back onto one domain, but that's still in progress sadly.

MusikAnimal subscribed.Jul 28 2016, 10:03 PM

Do we even need OAuth anymore? I believe it was introduced for XEcho, and cross-wiki notifications are native now.

Matthewrbowker added a comment.Jul 29 2016, 3:37 AM
In T132855#2503575, @MusikAnimal wrote:

Do we even need OAuth anymore? I believe it was introduced for XEcho, and cross-wiki notifications are native now.

Yes, it's used on the edit counter. Users can view their own advanced statistics without opting in globally.

Matthewrbowker moved this task from Backlog to Working on the XTools board.Nov 24 2016, 12:04 AM
Matthewrbowker removed Matthewrbowker as the assignee of this task.Apr 24 2017, 3:34 PM
Matthewrbowker moved this task from Working to Working on the XTools board.
Matthewrbowker added a subscriber: Samwilson.

@MusikAnimal @Samwilson One of you put oauth into the new xtools. Could you verify that it's set up OK (AKA the callback url will work even if we wind up under different tools by T163283: Investigation: XTools routing )?

Matthewrbowker moved this task from Working to General / other on the XTools board.Jul 17 2017, 9:35 PM
MusikAnimal closed this task as Resolved.Jul 18 2017, 12:01 AM
MusikAnimal claimed this task.
MusikAnimal moved this task from General / other to Complete on the XTools board.

Working in the new XTools https://xtools.wmflabs.org

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits