Page MenuHomePhabricator
Create Task
Maniphest T133317

[BUG] WDQS GUI auto completion doesn't work with unicode
Closed, ResolvedPublic
Actions

Description

Right now, we can display property hints in given language, but completion still works only in English. We may want to make completion work in current language instead.

Details

SubjectRepoBranchLines +/-
Fix: WDQS GUI auto completion doesn't work with unicodewikidata/query/guimaster+12 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Smalyshev created this task.Apr 21 2016, 5:54 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptApr 21 2016, 5:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Smalyshev added a parent task: T100475: [Epic] Add arbitrary language support.Apr 21 2016, 5:54 PM
Smalyshev moved this task from Incoming to GUI on the Wikidata-Query-Service board.
• Jonas added a comment.Apr 21 2016, 7:21 PM

Sorry, could you provide steps to reproduce?
I18N still needs the translations to be pushed from translatewiki to work.

Smalyshev moved this task from Needs triage to WDQS on the Discovery-ARCHIVED board.Apr 21 2016, 8:23 PM
Smalyshev added a comment.Apr 21 2016, 8:26 PM
  1. I switch language to Russian
  2. I load the Cats example
  3. I try to replace wdt:P31 with wdt:P279. When I start typing "под" which is the beginning of its Russian label (подкласс от) the right property is not found, however when I type "subclass" it is found. The tooltip correctly displays Russian label & description.
• Jonas added a comment.Apr 22 2016, 8:23 AM

OK, thanks.

I guess the problem is:
line.charAt( pos ).match( /\w/ ) in hint.Rdf

• Jonas renamed this task from WDQS GUI completion should work in current language to [BUG] WDQS GUI auto completion doesn't work in lang ru.Apr 22 2016, 8:25 AM
Lydia_Pintscher triaged this task as Low priority.Apr 25 2016, 9:59 AM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
• Jonas renamed this task from [BUG] WDQS GUI auto completion doesn't work in lang ru to [BUG] WDQS GUI auto completion doesn't work with unicode.Apr 25 2016, 11:25 AM
Ash_Crow subscribed.Apr 30 2016, 12:22 AM

Same problem with French. I tried to search for wd:île (island) and it didn't work.

gerritbot subscribed.May 9 2016, 4:20 PM

Change 287656 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fix: WDQS GUI auto completion doesn't work with unicode

https://gerrit.wikimedia.org/r/287656

gerritbot added a project: Patch-For-Review.May 9 2016, 4:20 PM
• Jonas mentioned this in rWDQGfc3e6f2c8959: Fix: WDQS GUI auto completion doesn't work with unicode.May 9 2016, 4:21 PM
• Jonas mentioned this in rWDQG62fc071f5c5e: Fix: WDQS GUI auto completion doesn't work with unicode.May 10 2016, 9:10 AM
gerritbot added a comment.May 11 2016, 8:26 PM

Change 287656 merged by jenkins-bot:
Fix: WDQS GUI auto completion doesn't work with unicode

https://gerrit.wikimedia.org/r/287656

• Jonas closed this task as Resolved.May 11 2016, 8:29 PM
• Jonas claimed this task.
• Jonas added a project: Wikidata-Sprint-2016-05-10.
• Jonas mentioned this in rWDQGedc14d33966e: Fix: WDQS GUI auto completion doesn't work with unicode.May 12 2016, 9:51 PM
Lydia_Pintscher moved this task from Proposed to Done on the Wikidata-Sprint-2016-05-10 board.May 16 2016, 3:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL