Page MenuHomePhabricator
Create Task
Maniphest T134206

[mobile] JSON displayed when editing Flow page
Closed, ResolvedPublic
Actions

Description

Split from T130322: [regression wmf.9] 'Edit title' pencil icon displayed as protected unnecessarily when viewing Flow page in MobileFrontend #4
The Flow pages have a big edit pencil icon displayed at the top of the page - see the screenshot. Clicking on it will display e.g.

IMG_0110 (1).PNG (2×1 px, 100 KB)

Details

SubjectRepoBranchLines +/-
Don't show edit link if editing is not supported for content handlermediawiki/extensions/MobileFrontendmaster+25 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 2 2016, 10:28 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 2 2016, 10:28 PM
Etonkovidova mentioned this in T130322: [regression wmf.9] 'Edit title' pencil icon displayed as protected unnecessarily when viewing Flow page in MobileFrontend.May 2 2016, 10:29 PM
• Mattflaschen-WMF removed a project: Collaboration-Team-Triage.May 2 2016, 11:02 PM
• Mattflaschen-WMF subscribed.

This should probably be in Q4, to make sure people can't just put arbitrary JSON and corrupt the page.

gerritbot subscribed.May 2 2016, 11:27 PM

Change 286545 had a related patch set uploaded (by Mattflaschen):
Don't show edit link if editing is not supported for content handler

https://gerrit.wikimedia.org/r/286545

gerritbot added a project: Patch-For-Review.May 2 2016, 11:27 PM
• Mattflaschen-WMF added a comment.May 2 2016, 11:27 PM
In T134206#2258185, @Mattflaschen wrote:

This should probably be in Q4, to make sure people can't just put arbitrary JSON and corrupt the page.

This couldn't happen, since editing was blocked by core with no-direct-editing.

The patch hides the link.

• Mattflaschen-WMF renamed this task from [mobile] JASON displayed when editing Flow page to [mobile] JSON displayed when editing Flow page.May 2 2016, 11:28 PM
• Mattflaschen-WMF claimed this task.
• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.
gerritbot added a comment.May 9 2016, 11:21 PM

Change 286545 merged by jenkins-bot:
Don't show edit link if editing is not supported for content handler

https://gerrit.wikimedia.org/r/286545

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 1:15 PM
SBisson moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 11 2016, 12:45 PM
Etonkovidova added a comment.May 12 2016, 12:34 AM

Checked in betalabs and media.m.mediawiki.org - the link for editing flow content is removed; other editing means can are functioning normally.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.May 12 2016, 12:35 AM
• jmatazzoni closed this task as Resolved.May 12 2016, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits