Page MenuHomePhabricator

Create tests for diff.html_comparator
Closed, ResolvedPublic

Description

html_comparator in the diff module does not have any tests.
Until the parent task , it was not working on Python 3 due to a syntax error.

Event Timeline

jayvdb created this task.May 4 2016, 6:16 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 4 2016, 6:16 AM
Restricted Application added subscribers: pywikibot-bugs-list, Zppix, Aklapper. · View Herald Transcript
AbdealiJK claimed this task.May 4 2016, 7:33 AM

Change 286791 had a related patch set uploaded (by AbdealiJK):
tests: Add pywikibot.diff.html_comparator() tests

https://gerrit.wikimedia.org/r/286791

Change 286791 merged by jenkins-bot:
tests: Add pywikibot.diff.html_comparator() tests

https://gerrit.wikimedia.org/r/286791

AbdealiJK closed this task as Resolved.May 15 2016, 11:15 PM

Change 289894 had a related patch set uploaded (by John Vandenberg):
Use flake8-mock and fix mock.assert_called_once

https://gerrit.wikimedia.org/r/289894

Change 289894 merged by jenkins-bot:
Use flake8-mock and fix mock.assert_called_once

https://gerrit.wikimedia.org/r/289894