Do not lazy load images on main page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It is unnecessary and currently broken in that it leads to a repaint. Let's avoid running on this page.

Details

	Subject	Repo	Branch	Lines +/-
	Add lazy loading images test for main page	mediawiki/extensions/MobileFrontend	master	+7 -0

Customize query in gerrit

Event Timeline

Jdlrobson created this task.May 4 2016, 7:51 PM

Restricted Application added subscribers: Zppix, TerraCodes, Aklapper. · View Herald TranscriptMay 4 2016, 7:51 PM

Jdlrobson added a project: Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 5 2016, 4:32 PM

dr0ptp4kt added a parent task: T134768: Deploy lazy loaded images to bn.m.wikipedia.org.May 9 2016, 3:08 PM

dr0ptp4kt added a parent task: T134003: Deploy lazy loaded images to a few more wikis.

Jdlrobson set the point value for this task to 1.May 9 2016, 4:15 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.

Jdlrobson triaged this task as Medium priority.May 9 2016, 4:58 PM

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 9 2016, 5:33 PM

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 9 2016, 5:53 PM

Change 287670 had a related patch set uploaded (by Jdlrobson):
Add lazy loading images test for main page

https://gerrit.wikimedia.org/r/287670

gerritbot added a project: Patch-For-Review.May 9 2016, 5:55 PM

Looking at this closely it seems that this bug is invalid. I've written a test that shows that section wrapping and lazy loaded images will not run on the main page.

I think possibly what happened here is an inline image without a height was in the main page causing a repaint. It wasn't related to lazy loaded images.

Thus removing this as a blocker.

Jdlrobson claimed this task.May 9 2016, 5:56 PM

Jdlrobson removed a parent task: T134768: Deploy lazy loaded images to bn.m.wikipedia.org.

Jdlrobson removed a parent task: T134003: Deploy lazy loaded images to a few more wikis.

• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 9 2016, 8:51 PM

Change 287670 merged by jenkins-bot:
Add lazy loading images test for main page

https://gerrit.wikimedia.org/r/287670

Jdlrobson closed this task as Resolved.May 9 2016, 9:46 PM

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 1:15 PM

Jdlrobson moved this task from Done to Ready for Signoff on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 16 2016, 6:00 PM