matchWikiprojectLink assumes language codes contain word characters when they may also contain dash
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lokal_Profil
	May 9 2016, 8:06 AM

Description

matchWikiprojectLink() fails on e.g. be-tarask since - is not a word character and so not caught by the \w+ regexp.

	Subject	Repo	Branch	Lines +/-
	Limit language codes to lower case or hyphen	labs/tools/heritage	master	+16 -1

Status	Assigned	Task
Resolved	JeanFred	T131714 Hold a Wiki Loves Monuments coding sprint at Wikimedia Hackathon 2016
Resolved	Lokal_Profil	T112415 Rename wikipedia:be-x-old to be-tarask in the Monuments Database
Resolved	Lokal_Profil	T134728 matchWikiprojectLink assumes language codes contain word characters when they may also contain dash

Change 287573 had a related patch set uploaded (by Lokal Profil):
Limit language codes to lower case or hyphen

Change 287573 merged by jenkins-bot:
Limit language codes to lower case or hyphen

Mentioned in SAL [2016-05-09T11:15:41Z] <JeanFred> Deployed latest from Git: 4f82b32 (T134728)

Link does <s>not</s> look pretty :)

My fault. It should definitely have read "less ugly" :)

In T134728#2275754, @Lokal_Profil wrote:

My fault. It should definitely have read "less ugly" :)

What a slip! I did mean to write « does look pretty » XD