Page MenuHomePhabricator
Create Task
Maniphest T135001

Migrate PHPUnit MediaWiki core jobs to Nodepool
Closed, ResolvedPublic
Actions

Description

Track migration of PHPUnit jobs for mediawiki/core to Nodepool.

OKmediawiki-phpunit-hhvm
OKmediawiki-phpunit-hhvm-composer https://gerrit.wikimedia.org/r/#/c/342478/
OKmediawiki-phpunit-php55
OKmediawiki-phpunit-parsertests-php55
OKmediawiki-phpunit-parsertests-hhvm 

The the jobs from extension-gate, the qunit one got migrated already and the whole clones takes roughly a minute which is good enough for now.

OKmediawiki-extensions-hhvmhttps://gerrit.wikimedia.org/r/#/c/324477/
OKmediawiki-extensions-php55https://gerrit.wikimedia.org/r/#/c/324477/

Details

SubjectRepoBranchLines +/-
Migrate mediawiki-phpunit-phpflavour-composer to nodepoolintegration/configmaster+100 -32
mediawiki-phpunit-hhvm-composer to Nodepoolintegration/configmaster+8 -7
Drop mediawiki-extensions jobs that ran on permanent slavesintegration/configmaster+3 -1
Switch mediawiki-extensions-* jobs to Nodepoolintegration/configmaster+8 -11
mediawiki-extensions-* jobs on Nodepoolintegration/configmaster+28 -1
Remove obsolete MediaWiki jobsintegration/configmaster+6 -28
Mediawiki core/vendor PHPUnit jobs to Nodepoolintegration/configmaster+87 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.May 11 2016, 2:36 PM
Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 11 2016, 2:36 PM
hashar updated the task description. (Show Details)May 11 2016, 2:37 PM
gerritbot added a comment.May 11 2016, 2:39 PM

Change 286497 had a related patch set uploaded (by Hashar):
(WIP) Mediawiki PHPUnit to Nodepool (WIP)

https://gerrit.wikimedia.org/r/286497

gerritbot added a project: Patch-For-Review.May 11 2016, 2:39 PM
hashar added a comment.May 11 2016, 2:41 PM

The jobs pass based on some random tests run:

https://integration.wikimedia.org/ci/job/mediawiki-phpunit-php55-trusty/4/consoleFull

https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-jessie/6/consoleFull

https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-trusty/7/consoleFull

I have added a bunch of .deb packages on the instances. Probably more need to be added.

hashar added a comment.May 11 2016, 3:23 PM

Triggering jobs manually from gallium.wikimedia.org:/home/hashar with:

./trigger-job.py --job mediawiki-phpunit-php55-trusty --branch master --project mediawiki/core &
./trigger-job.py --job mediawiki-phpunit-hhvm-jessie --branch master --project mediawiki/core &
./trigger-job.py --job mediawiki-phpunit-hhvm-trusty --branch master --project mediawiki/core &

./trigger-job.py --job mediawiki-parsertests-php55-trusty --branch master --project mediawiki/core &
./trigger-job.py --job mediawiki-parsertests-hhvm-jessie --branch master --project mediawiki/core &
./trigger-job.py --job mediawiki-parsertests-hhvm-trusty --branch master --project mediawiki/core &

That hook directly into the Gearman server.

hashar added a comment.May 11 2016, 4:21 PM

PHPUnit without parser tests:

JobStatus
mediawiki-phpunit-php55-trustyTests: 11198, Assertions: 71225, Skipped: 27.
mediawiki-phpunit-hhvm-trustyTests: 11201, Assertions: 72109, Skipped: 116.
mediawiki-phpunit-hhvm-jessieTests: 11201, Assertions: 72109, Skipped: 116.

Zend 5.5 apparently miss the xhprof extension though I have added it. There is also a bunch of Tidy not found.

HHVM is mostly SKIPPED: tidy extension is not installed.. See below.

parsertests suite:

JobStatus
mediawiki-parsertests-hhvm-jessieTests: 1339, Assertions: 2573, Skipped: 103.
mediawiki-parsertests-hhvm-trustyTests: 1339, Assertions: 2573, Skipped: 103.
mediawiki-parsertests-php55-trustyOK (1339 tests, 2676 assertions)

The 103 skipped tests under HHVM are all due to SKIPPED: tidy extension is not installed.. Ie either the hhvm-tidy extension is not loaded or it is not recognized by our test suite.

hashar added a comment.EditedMay 11 2016, 4:23 PM

Trusty images have xhprof:

php5-xhprof:
  Installed: 0.9.4-1build1
  Candidate: 0.9.4-1build1
  Version table:
 *** 0.9.4-1build1 0
        500 http://nova.clouds.archive.ubuntu.com/ubuntu/ trusty/universe amd64 Packages
        100 /var/lib/dpkg/status

Retriggered https://integration.wikimedia.org/ci/job/mediawiki-phpunit-php55-trusty/7/console

hashar added a comment.May 12 2016, 9:37 AM

xhprof module is enabled via https://gerrit.wikimedia.org/r/#/c/288357/ and https://gerrit.wikimedia.org/r/#/c/288358/

hashar added a comment.May 12 2016, 12:13 PM
mediawiki-parsertests-hhvm-jessieTests: 1339, Assertions: 2573, Skipped: 103.
mediawiki-parsertests-hhvm-trustyTests: 1339, Assertions: 2573, Skipped: 103.
mediawiki-parsertests-php55-trustyOK (1339 tests, 2676 assertions)
mediawiki-phpunit-hhvm-jessieTests: 9881, Assertions: 69563, Skipped: 13.
mediawiki-phpunit-hhvm-trustyTests: 9881, Assertions: 69563, Skipped: 13.
mediawiki-phpunit-php55-trustyTests: 9881, Assertions: 69553, Skipped: 15.

hhvm on Jessie and Trusty do not behave the same :(

gerritbot added a comment.May 12 2016, 3:02 PM

Change 286497 merged by jenkins-bot:
Mediawiki core/vendor PHPUnit jobs to Nodepool

https://gerrit.wikimedia.org/r/286497

hashar added a comment.May 12 2016, 3:10 PM

Bunch of changes got enqueued and they seem to pass just fine \O/

Next are the gate jobs:

mediawiki-extensions-hhvm
mediawiki-extensions-php55

hashar moved this task from Backlog to In progress on the Continuous-Integration-Config board.May 12 2016, 3:10 PM
hashar moved this task from Backlog to In-progress on the Continuous-Integration-Scaling board.
Stashbot added a comment.May 13 2016, 9:59 AM

Mentioned in SAL [2016-05-13T09:59:05Z] <hashar> Deleting non nodepool mediawiki PHPUnit jobs for T135001 (mediawiki-phpunit-hhvm mediawiki-phpunit-parsertests-hhvm mediawiki-phpunit-parsertests-php55 mediawiki-phpunit-php55)

hashar updated the task description. (Show Details)May 13 2016, 10:00 AM
gerritbot added a comment.May 13 2016, 10:02 AM

Change 288586 had a related patch set uploaded (by Hashar):
Remove obsolete MediaWiki jobs

https://gerrit.wikimedia.org/r/288586

gerritbot added a comment.May 13 2016, 10:15 AM

Change 288586 merged by jenkins-bot:
Remove obsolete MediaWiki jobs

https://gerrit.wikimedia.org/r/288586

• adrianheine unsubscribed.May 15 2016, 2:59 PM
gerritbot added a comment.May 25 2016, 9:41 PM

Change 290806 had a related patch set uploaded (by Paladox):
Migrate mediawiki-phpunit-phpflavour-composer to nodepool

https://gerrit.wikimedia.org/r/290806

hashar updated the task description. (Show Details)Jun 6 2016, 1:59 PM
greg removed a project: releng-201516-q4.Jun 21 2016, 9:35 PM
gerritbot added a comment.Nov 30 2016, 2:44 PM

Change 324456 had a related patch set uploaded (by Hashar):
mediawiki-extensions-* jobs on Nodepool

https://gerrit.wikimedia.org/r/324456

hashar updated the task description. (Show Details)Nov 30 2016, 2:45 PM
gerritbot added a comment.Nov 30 2016, 3:51 PM

Change 324456 merged by jenkins-bot:
mediawiki-extensions-* jobs on Nodepool

https://gerrit.wikimedia.org/r/324456

gerritbot added a comment.Nov 30 2016, 4:20 PM

Change 324477 had a related patch set uploaded (by Hashar):
Switch to mediawiki-extensions-* jobs

https://gerrit.wikimedia.org/r/324477

gerritbot added a comment.Dec 1 2016, 8:18 AM

Change 324477 merged by jenkins-bot:
Switch mediawiki-extensions-* jobs to Nodepool

https://gerrit.wikimedia.org/r/324477

gerritbot added a comment.Dec 2 2016, 2:31 PM

Change 324913 had a related patch set uploaded (by Hashar):
Drop mediawiki-extensions jobs that ran on permanent slaves

https://gerrit.wikimedia.org/r/324913

gerritbot added a comment.Dec 2 2016, 2:35 PM

Change 324913 merged by jenkins-bot:
Drop mediawiki-extensions jobs that ran on permanent slaves

https://gerrit.wikimedia.org/r/324913

gerritbot added a comment.Mar 13 2017, 4:30 PM

Change 342478 had a related patch set uploaded (by Hashar):
[integration/config] mediawiki-phpunit-hhvm-composer to Nodepool

https://gerrit.wikimedia.org/r/342478

hashar updated the task description. (Show Details)Mar 13 2017, 4:35 PM
hashar updated the task description. (Show Details)Mar 13 2017, 4:38 PM
gerritbot added a comment.Mar 13 2017, 4:38 PM

Change 342478 merged by jenkins-bot:
[integration/config] mediawiki-phpunit-hhvm-composer to Nodepool

https://gerrit.wikimedia.org/r/342478

hashar closed this task as Resolved.Mar 13 2017, 4:38 PM
gerritbot added a comment.Apr 14 2017, 1:50 PM

Change 290806 abandoned by Hashar:
Migrate mediawiki-phpunit-phpflavour-composer to nodepool

Reason:
Obsolete.

https://gerrit.wikimedia.org/r/290806

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits