Page MenuHomePhabricator
Create Task
Maniphest T135200

Upload Wizard for Wikimedia Commons does not complete process, freezes after last click, if only one file was selected
Closed, ResolvedPublic
Actions

Description

Sanborn Manhattan V. 1 Plate 012 publ. 1905.jpg (6×4 px, 7 MB)

Screen Shot 2016-05-12 at 8.26.49 PM.png (968×1 px, 158 KB)

  1. Open upload Wizard in Safari
  2. Follow all instructions to upload the attached file
  3. Click on the last "Next" button
  4. I should see a spinning gear, and the messages (progressively) "Queued", something, "Publishing", followed by "Thanks for uploading!"
  5. What I see is the static picture on the attached screenshot

I am using Mac OS 10.11.4 and Safari 9.1. I get the same result with Chrome Version 50.0.2661.94 (64-bit).

Just for protocol the same problem appears using Window7/Opera.

Details

SubjectRepoBranchLines +/-
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element' of undefined'mediawiki/extensions/UploadWizardwmf/1.28.0-wmf.1+3 -1
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element' of undefined'mediawiki/extensions/UploadWizardmaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Vzeebjtf created this task.May 13 2016, 12:51 AM
Restricted Application added subscribers: Zppix, Steinsplitter, Aklapper. · View Herald TranscriptMay 13 2016, 12:51 AM
matmarex claimed this task.May 13 2016, 12:59 AM
matmarex added a project: UploadWizard.
matmarex updated the task description. (Show Details)
Restricted Application added a project: Multimedia. · View Herald TranscriptMay 13 2016, 12:59 AM
LacoR updated the task description. (Show Details)May 13 2016, 12:23 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptMay 13 2016, 12:23 PM
LacoR subscribed.May 13 2016, 12:24 PM
matmarex merged tasks: T135233: Upload Wizard getting stuck on the 'Describe' step for a single image upload, T135231: Problème lors du chargement de photo, T135220: UploadWizard Commons get stuck in process, T135218: Wikimedia Commons uploads failing.May 13 2016, 2:18 PM
matmarex added subscribers: Nemo_bis, darthbhyrava, JGS25 and 4 others.

I'm sorry, this is a bug caused by a really stupid mistake I made in 189a5572cc08ac46dc0dba1f7293d5967ee8c7ba, which was deployed to Commons yesterday evening. The upload would always fail if you selected only one file (uploads of multiple files would succeed, which is presumably why we missed it in testing, and why we didn't notice the fall in numbers of files being uploaded with UploadWizard).

I have already deployed a workaround to Commons: https://commons.wikimedia.org/w/index.php?title=MediaWiki:Common.js&diff=196165190&oldid=190856441 and the issue should be fixed there. I'll have the proper patch deployed on Monday (and I'll revert the MediaWiki:Common.js workaround).

gerritbot subscribed.May 13 2016, 2:20 PM

Change 288610 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element' of undefined'

https://gerrit.wikimedia.org/r/288610

gerritbot added a project: Patch-For-Review.May 13 2016, 2:20 PM
matmarex renamed this task from Upload Wizard for Wikimedia Commons does not complete process, freezes after last click to Upload Wizard for Wikimedia Commons does not complete process, freezes after last click, if only one file was selected.May 13 2016, 2:24 PM
matmarex triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 13 2016, 2:24 PM
gerritbot added a comment.May 13 2016, 9:42 PM

Change 288610 merged by jenkins-bot:
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element' of undefined'

https://gerrit.wikimedia.org/r/288610

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 13 2016, 10:00 PM
gerritbot added a comment.May 13 2016, 10:40 PM

Change 288715 had a related patch set uploaded (by Bartosz Dziewoński):
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element' of undefined'

https://gerrit.wikimedia.org/r/288715

TerraCodes added a comment.EditedMay 14 2016, 3:54 AM

I think this is related but I'm not 100% sure.
https://en.wikipedia.org/wiki/User_talk:Antonybarkur#Image_upload_error

I am getting the following error while uploading an image: Unknown error: "{"xhr":{"readyState":4,"responseText":"'origin' parameter does not match Origin header\n","status":403,"statusText":"Forbidden"},"textStatus":"error","exception":"Forbidden

Nemo_bis unsubscribed.May 14 2016, 9:32 AM
matmarex added a comment.May 14 2016, 11:37 AM

No, it's not related.

Lokal_Profil added a comment.May 14 2016, 2:44 PM
This comment was removed by Lokal_Profil.
gerritbot added a comment.May 16 2016, 11:09 PM

Change 288715 merged by jenkins-bot:
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element' of undefined'

https://gerrit.wikimedia.org/r/288715

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 17 2016, 12:00 AM
matmarex added a comment.May 17 2016, 2:33 AM

Workaround reverted: https://commons.wikimedia.org/w/index.php?title=MediaWiki:Common.js&diff=196460752&oldid=196165190

matmarex closed this task as Resolved.May 17 2016, 2:36 AM
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits