Page MenuHomePhabricator
Create Task
Maniphest T135481

Unexpected general module 'ext.translate.messagetable' in styles queue.
Closed, ResolvedPublic
Actions

Description

Observed on Special:LanguageStats debug output.

Details

SubjectRepoBranchLines +/-
Remove unused ext.translate.messagetable from Special:LanguageStatsmediawiki/extensions/Translatemaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.May 17 2016, 8:58 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 8:58 AM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.May 17 2016, 8:58 AM
Danny_B renamed this task from [resourceloader] Unexpected general module 'ext.translate.messagetable' in styles queue. to Unexpected general module 'ext.translate.messagetable' in styles queue..May 17 2016, 9:51 AM
Danny_B added a project: MediaWiki-ResourceLoader.
Krinkle removed a project: MediaWiki-ResourceLoader.May 19 2016, 7:08 PM
Krinkle subscribed.May 19 2016, 7:29 PM

This warning doesn't exist in MediaWiki yet. Presumably you applied https://gerrit.wikimedia.org/r/#/c/288026/ (unmerged, WIP) locally on translatewiki.net?

That's cool :). The warning seems genuine though. The module has both scripts and styles registered (mwext-Translate.git:/Resources.php#L153), and loaded via addModuleStyles (mwext-Translate.git:/specials/SpecialLanguageStats.php#L121) - which will no longer be allowed in the future.

See also T92459, and back story at https://lists.wikimedia.org/pipermail/wikitech-l/2016-May/085479.html.

Nikerabbit added a comment.May 20 2016, 5:17 AM

Yep I applied it locally on my dev instance to have early warnings :)

Nikerabbit triaged this task as Medium priority.May 20 2016, 5:18 AM
gerritbot subscribed.May 20 2016, 11:34 AM

Change 289845 had a related patch set uploaded (by Nikerabbit):
Remove unused ext.translate.messagetable from Special:LanguageStats

https://gerrit.wikimedia.org/r/289845

gerritbot added a project: Patch-For-Review.May 20 2016, 11:34 AM
Nikerabbit lowered the priority of this task from Medium to Low.May 20 2016, 11:34 AM
Nikerabbit added a project: Language-Q4-2016-Sprint 3.
Nikerabbit moved this task from Backlog to In Review on the Language-Q4-2016-Sprint 3 board.
Nikerabbit added a project: Unplanned-Sprint-Work.May 20 2016, 11:37 AM
Krinkle awarded a token.May 20 2016, 5:54 PM
gerritbot added a comment.May 23 2016, 7:35 AM

Change 289845 merged by jenkins-bot:
Remove unused ext.translate.messagetable from Special:LanguageStats

https://gerrit.wikimedia.org/r/289845

Nikerabbit moved this task from In Review to Done on the Language-Q4-2016-Sprint 3 board.May 23 2016, 7:54 AM
Nikerabbit edited projects, added MW-1.28-release (WMF-deploy-2016-05-24_(1.28.0-wmf.3)); removed Patch-For-Review.May 30 2016, 12:36 PM
Nikerabbit claimed this task.May 30 2016, 2:14 PM
Arrbee closed this task as Resolved.May 31 2016, 6:54 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL