Page MenuHomePhabricator
Create Task
Maniphest T135701

Travis apt addon not working for matrix: include:
Closed, ResolvedPublic
Actions

Description

Travis APT addon feature has been used to install

  • djvulibre-bin
  • graphviz
  • liblua5.1-dev

Travis has not been executing the APT addon for the jobs in the matrix: include: section after 8004cdfe29 due to https://github.com/travis-ci/travis-ci/issues/5405 . See build #2754.9 for the first job log without the APT packages section at the top, compared to build #2753

i.e. the following are not the same

os: linux
os:
  - linux

The apt: addon is inherited in matrix: include: in the former, but not in the latter.

The unit tests automatically skip tests, and this went unnoticed.

At least djvu tests downgraded to skip some tests.

graphviz and liblua5.1-dev are not used by all of these jobs, as the relevant tests depend on python modules which are only installed with PYSETUP_TEST_EXTRAS=1 (or requirements.txt, but that came later)

Details

SubjectRepoBranchLines +/-
Re-enable APT addon for jobs in matrix includepywikibot/coremaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

jayvdb created this task.May 19 2016, 4:20 AM
Restricted Application added subscribers: pywikibot-bugs-list, Zppix, Aklapper. · View Herald TranscriptMay 19 2016, 4:20 AM
jayvdb updated the task description. (Show Details)May 19 2016, 4:26 AM
jayvdb moved this task from Backlog to Reported Upstream on the Upstream board.May 19 2016, 2:26 PM
gerritbot subscribed.May 19 2016, 2:31 PM

Change 289659 had a related patch set uploaded (by John Vandenberg):
Re-enable APT addon for jobs in matrix include

https://gerrit.wikimedia.org/r/289659

gerritbot added a project: Patch-For-Review.May 19 2016, 2:31 PM
jayvdb added a parent task: T134647: site detection test fails for proofwiki on Travis precise images before May 2015.May 19 2016, 3:14 PM
AbdealiJK subscribed.May 19 2016, 4:47 PM

Possibly a comment for a new Phab task:
I think there is an underlying issue about the fact that when pytest skips tests, travis doesn't fail.
There was an issue on pytest about this a while back which I had given up on which I have reinitiated conversation about:
https://github.com/pytest-dev/pytest/issues/1364

Based on that discussion: if we're using pytest, one possible method would be to override the unittest.skipIf decorators in the tests/__init__.py where we already do try/catch for unittest2 to add a pytest fixture which is later handled in conftest.

This was we can specify which tests (or how many tests) should skip in each CI job using an env variable or in the tox.ini

jayvdb mentioned this in T135795: CI expected failures and skips.May 20 2016, 3:11 AM
jayvdb added a comment.May 20 2016, 3:40 AM

Created T135795: CI expected failures and skips.

gerritbot added a comment.May 20 2016, 8:19 AM

Change 289659 merged by jenkins-bot:
Re-enable APT addon for jobs in matrix include

https://gerrit.wikimedia.org/r/289659

jayvdb closed this task as Resolved.May 20 2016, 11:13 AM
jayvdb claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits