Citoid should recognise per cent-encoded URLs and avoid double-encoding them
Closed, DuplicatePublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	zhaofengli
	Jun 3 2016, 4:52 AM

Description

Steps to reproduce

Click the Cite button in VisualEditor
Paste in https://zhaofeng.li/sandbox/ .html. The reference will be generated correctly.
Paste in https://zhaofeng.li/sandbox/%20.html. It will fail to generate a citation.

Why?

Because the URL is automatically (re-)encoded in ve.ui.CiteFromIdInspector.js before the request is sent, changing "%20" to "%2520". In order to prevent double-encoding, the script should decode the URL first.

References

Related Objects

Mentioned In: T141342: Citoid extension/ VE should recognise angle brackets and HTML-encode them
T140990: Citing url with urlencoded string for < > fails
Mentioned Here: T146539: Some input to Citoid extension, may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input to citoid.

Event Timeline

zhaofengli created this task.Jun 3 2016, 4:52 AM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 3 2016, 4:52 AM

zhaofengli added a subscriber: Sphilbrick.Jun 3 2016, 5:07 AM

Jdforrester-WMF renamed this task from Double-encoding when processing an already-encoded URL to Citoid should recognise per cent-encoded URLs and avoid double-encoding them.Jul 19 2016, 7:14 PM

Jdforrester-WMF triaged this task as Low priority.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Josve05a mentioned this in T140990: Citing url with urlencoded string for < > fails.Jul 21 2016, 6:54 PM

Josve05a merged a task: T140990: Citing url with urlencoded string for < > fails.Jul 21 2016, 7:03 PM

Josve05a added subscribers: Josve05a, Jdforrester-WMF.

Jdforrester-WMF mentioned this in T141342: Citoid extension/ VE should recognise angle brackets and HTML-encode them.Jul 26 2016, 7:07 PM

Jdforrester-WMF set the point value for this task to 1.Aug 1 2016, 4:56 PM

Jdforrester-WMF moved this task from TR0: Interrupt to External and Administrivia on the VisualEditor board.Aug 9 2016, 7:36 PM

Closing this one instead of the other because patch is associated with T146539 ^-^

Citoid should recognise per cent-encoded URLs and avoid double-encoding themClosed, DuplicatePublic1 Estimated Story PointsActions