Page MenuHomePhabricator

RecentChanges in elwiki throws an exception
Closed, ResolvedPublic

Description

RecentChanges in elwiki is not working at all, it responds:

Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException"

https://el.wikipedia.org/wiki/%CE%95%CE%B9%CE%B4%CE%B9%CE%BA%CF%8C:%CE%A0%CF%81%CF%8C%CF%83%CF%86%CE%B1%CF%84%CE%B5%CF%82%CE%91%CE%BB%CE%BB%CE%B1%CE%B3%CE%AD%CF%82

Event Timeline

geraki created this task.Jun 6 2016, 5:33 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 6 2016, 5:33 AM
geraki triaged this task as Unbreak Now! priority.Jun 6 2016, 5:33 AM
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptJun 6 2016, 5:33 AM
aaron added a subscriber: aaron.Jun 6 2016, 5:59 AM

From <<'select * from recentchanges where rc_title='' order by rc_timestamp desc limit 5;>> I see rows in RC like:

stdClass Object
(
    [rc_id] => 10554958
    [rc_timestamp] => 20160605214458
    [rc_cur_time] => 
    [rc_user] => 198733
    [rc_user_text] => Svarnase
    [rc_namespace] => 0
    [rc_title] => 
    [rc_comment] => 
    [rc_minor] => 0
    [rc_bot] => 0
    [rc_new] => 0
    [rc_cur_id] => 0
    [rc_this_oldid] => 0
    [rc_last_oldid] => 0
    [rc_type] => 3
    [rc_source] => mw.log
    [rc_moved_to_ns] => 0
    [rc_moved_to_title] => 
    [rc_patrolled] => 1
    [rc_ip] => <X>
    [rc_old_len] => 
    [rc_new_len] => 
    [rc_deleted] => 0
    [rc_logid] => 535761
    [rc_log_type] => eparticle
    [rc_log_action] => selfremove
    [rc_params] => a:2:{s:13:"4::coursename";s:120:"Education Program:Αριστοτέλειο Πανεπιστήμιο Θεσσαλονίκης/Μαθηματικό (2016)";s:8:"5::owner";a:2:{i:0;i:198733;i:1;s:8:"Svarnase";}}
)

I wonder if these EducationProgram rows are causing the empty title exception triggered from addResultToCache(). Maybe the addBadLinkObj() code path should skip iterations where the title is empty...

Change 292890 had a related patch set uploaded (by Aaron Schulz):
Avoid exceptions for empty titles in addResultToCache() for sanity

https://gerrit.wikimedia.org/r/292890

Change 292891 had a related patch set uploaded (by Aaron Schulz):
Avoid exceptions for empty titles in addResultToCache() for sanity

https://gerrit.wikimedia.org/r/292891

Change 292891 merged by jenkins-bot:
Avoid exceptions for empty titles in addResultToCache() for sanity

https://gerrit.wikimedia.org/r/292891

aaron added a comment.Jun 6 2016, 7:42 AM

Backtraces were:

{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/title/TitleValue.php","line":82,"function":"parameter","class":"Wikimedia\\Assert\\Assert","type":"::","args":["boolean","string","string"]}, 
{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/cache/LinkBatch.php","line":171,"function":"__construct","class":"TitleValue","type":"->","args":["integer","string"]},
{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/cache/LinkBatch.php","line":135,"function":"addResultToCache","class":"LinkBatch","type":"->","args":["LinkCache","ResultWrapper"]},
 {"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/cache/LinkBatch.php","line":122,"function":"executeInto","class":"LinkBatch","type":"->","args":["LinkCache"]}, {"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/specialpage/ChangesListSpecialPage.php","line":75,"function":"execute","class":"LinkBatch","type":"->","args":[]}, 
{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/specials/SpecialRecentchanges.php","line":66,"function":"execute","class":"ChangesListSpecialPage","type":"->","args":["NULL"]}, 
{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/specialpage/SpecialPage.php","line":479,"function":"execute","class":"SpecialRecentChanges","type":"->","args":["NULL"]}, 
{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/specialpage/SpecialPageFactory.php","line":591,"function":"run","class":"SpecialPage","type":"->","args":["NULL"]},
 {"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/MediaWiki.php","line":282,"function":"executePath","class":"SpecialPageFactory","type":"::","args":["Title","RequestContext"]}, 
{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/MediaWiki.php","line":746,"function":"performRequest","class":"MediaWiki","type":"->","args":[]}, 
{"file":"/srv/mediawiki/php-1.28.0-wmf.4/includes/MediaWiki.php","line":520,"function":"main","class":"MediaWiki","type":"->","args":[]}, {"file":"/srv/mediawiki/php-1.28.0-wmf.4/index.php","line":43,"function":"run","class":"MediaWiki","type":"->","args":[]},
 {"file":"/srv/mediawiki/w/index.php","line":3,"function":"include","args":["string"]}

Change 292890 merged by jenkins-bot:
Avoid exceptions for empty titles in addResultToCache() for sanity

https://gerrit.wikimedia.org/r/292890