Dialog opening transforms are not animated in Firefox, weird 'undefined' transition is set
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jun 6 2016, 6:22 PM

Description

Dialog (any) opening/closing transforms are not animated in Firefox.
In the style attribute for <div class="oo-ui-window-frame"> there is transition: undefined 0s ease 0s. Something goes wrong in Window#withoutSizeTransitions, maybe? Noticed when investigating T135808.

Details

	Subject	Repo	Branch	Lines +/-
	Window#withoutSizeTransitions: Build transition property using sub-properties	oojs/ui	master	+12 -9

Customize query in gerrit

Related Objects

Mentioned In: T135808: "Start editing" popup can't be dismissed without clicking "Start editing"
Mentioned Here: T135808: "Start editing" popup can't be dismissed without clicking "Start editing"

Event Timeline

matmarex created this task.Jun 6 2016, 6:22 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 6 2016, 6:22 PM

matmarex mentioned this in T135808: "Start editing" popup can't be dismissed without clicking "Start editing".Jun 6 2016, 6:32 PM

Volker_E updated the task description. (Show Details)Jul 7 2016, 7:21 AM

Simple Dialog (full) from the demos gets a transition applied in contrast to all other Simple Dialogs.

@matmarex Something's wrong with [[ https://github.com/wikimedia/oojs-ui/blob/master/src/Window.js#L229 | styleObj and re-applying it]] here in Firefox.

Srdjan subscribed.Aug 7 2016, 10:50 AM

Change 311986 had a related patch set uploaded (by Prtksxna):
Window#withoutSizeTransitions: Build transition property using sub-properties

https://gerrit.wikimedia.org/r/311986

gerritbot added a project: Patch-For-Review.Sep 21 2016, 1:33 PM

• Prtksxna claimed this task.Sep 21 2016, 1:33 PM

• Prtksxna triaged this task as Medium priority.

• Prtksxna moved this task from Backlog to Doing on the OOUI board.

Change 311986 merged by jenkins-bot:
Window#withoutSizeTransitions: Build transition property using sub-properties

https://gerrit.wikimedia.org/r/311986

Jdforrester-WMF closed this task as Resolved.Sep 22 2016, 7:11 PM

Jdforrester-WMF moved this task from Doing to OOjs-UI-0.18.0 on the OOUI board.

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.18.0); removed OOUI.

Jdforrester-WMF removed a project: Patch-For-Review.

Dialog opening transforms are not animated in Firefox, weird 'undefined' transition is setClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Dialog opening transforms are not animated in Firefox, weird 'undefined' transition is set
Closed, ResolvedPublic
Actions