Page MenuHomePhabricator
Create Task
Maniphest T137319

Graph Display icons should have explanatory tooltips
Closed, ResolvedPublic
Actions

Description

When query's display setting is set to "Graph" (Display -> Graph), there are four icons/buttons in the center of the line containing the "Run"/"Clear"/"Display"/"Download"/"Link" buttons. It is not clear what any of the four buttons do. The buttons should have either tooltips or associated text explaining what they do.

Details

SubjectRepoBranchLines +/-
Add explanatory tooltips for GraphResultBrowser display iconswikidata/query/guimaster+25 -8
Add explanatory tooltips for Graph display iconswikidata/query/guimaster+23 -8
Customize query in gerrit

Related Objects

Event Timeline

Yair_rand created this task.Jun 8 2016, 3:44 PM
Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptJun 8 2016, 3:44 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript
Smalyshev moved this task from Incoming to GUI on the Wikidata-Query-Service board.Jun 8 2016, 4:22 PM
Smalyshev triaged this task as Medium priority.Sep 12 2016, 10:38 PM
hoo added a project: Ladies-That-FOSS-Wikidata.Oct 29 2016, 6:53 AM
Designbygio claimed this task.Oct 29 2016, 12:22 PM
Addshore subscribed.Nov 7 2016, 9:45 AM

@Designbygio Do you still plan on working on this task?
If not I will add it to Google-Code-In-2016

Addshore added a project: Google-Code-In-2016.Nov 7 2016, 9:45 AM
Designbygio added a comment.Nov 7 2016, 11:27 AM

Hi @Addshore! Actually yes my idea was still to work on this, i'm stack since i need more info on how internazionalization work but i have a branch with most of the work done.
Anyway if you think someone else could be faster then me, i will just pick up a new task

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 27 2016, 11:23 PM

This task might welcome instructions for a contributor how to set the "query's display setting".

Imported as https://codein.withgoogle.com/tasks/5099137976500224/

• Jonas updated the task description. (Show Details)Nov 28 2016, 10:45 AM
Designbygio removed Designbygio as the assignee of this task.Nov 28 2016, 9:45 PM
Designbygio subscribed.

unfortunately i wasn't able to figured out the localization part of the task in short time, i prefer leave the task available so someone else can pick up and in case i will figured out the solution in the next days. i just assign it again to my self.

• Jonas subscribed.Nov 29 2016, 8:30 AM

i18n is implemented in the parent:
https://github.com/wikimedia/wikidata-query-gui/blob/master/wikibase/queryService/ui/resultBrowser/AbstractResultBrowser.js#L186

divadsn claimed this task.EditedJan 3 2017, 7:51 AM
divadsn subscribed.

Where I am supposed to start? Should this fix also support l18n messages?

Edit: Found the repo, I am going to fix this now.

gerritbot subscribed.Jan 3 2017, 6:58 PM

Change 330259 had a related patch set uploaded (by Divadsn):
Add explanatory tooltips for Graph display icons

https://gerrit.wikimedia.org/r/330259

gerritbot added a project: Patch-For-Review.Jan 3 2017, 6:58 PM
divadsn mentioned this in rWDQGa69ebd7527eb: Add explanatory tooltips for Graph display icons.Jan 3 2017, 6:59 PM
divadsn mentioned this in rWDQG245873d1ad7b: Add explanatory tooltips for Graph display icons.Jan 4 2017, 1:12 PM
divadsn mentioned this in rWDQGaf8db5a5cc06: Add explanatory tooltips for Graph display icons.
divadsn mentioned this in rWDQGb6b23b6f3f12: Add explanatory tooltips for Graph display icons.Jan 4 2017, 9:41 PM
gerritbot added a comment.Jan 4 2017, 11:42 PM

Change 330259 merged by jenkins-bot:
Add explanatory tooltips for Graph display icons

https://gerrit.wikimedia.org/r/330259

divadsn closed this task as Resolved.Jan 5 2017, 6:33 AM

Change has been merged, hence marking this as resolved.

• Jonas reopened this task as Open.Jan 5 2017, 11:31 AM

Sorry, but this ticket is for for those buttons:

pasted_file (702×1 px, 205 KB)

divadsn added a comment.Jan 5 2017, 2:11 PM

I am sorry, but in the screenshot given in the bug report actually wasn't any buttons in the middle.

• Jonas added a comment.Jan 5 2017, 2:22 PM

Here is the link: http://tinyurl.com/hnqskun
You have to click run to see the buttons.

divadsn added a comment.EditedJan 5 2017, 2:26 PM

Thanks! I will look into that tonight and provide a next patch.

divadsn added a comment.Jan 6 2017, 6:47 PM
This comment was removed by divadsn.
divadsn added a comment.Jan 12 2017, 11:35 AM

@Jonas could you please explain what these buttons are acutally supposed to do, so I can make proper i18n messages? :)

• Jonas added a comment.Jan 12 2017, 4:21 PM

From left to right:

  • Stabilize network
  • Hierarchical Layout left to right
  • Hierarchical Layout up to down
  • Hierarchical Layout right to left

Thanks!

gerritbot added a comment.Jan 14 2017, 12:11 PM

Change 332041 had a related patch set uploaded (by Divadsn):
Add explanatory tooltips for GraphResultBrowser display icons

https://gerrit.wikimedia.org/r/332041

divadsn mentioned this in rWDQG789443edac36: Add explanatory tooltips for GraphResultBrowser display icons.Jan 14 2017, 12:12 PM
divadsn mentioned this in rWDQG619864f89c9e: Add explanatory tooltips for GraphResultBrowser display icons.Jan 14 2017, 12:14 PM
divadsn mentioned this in rWDQGf1828746eab4: Add explanatory tooltips for GraphResultBrowser display icons.Jan 14 2017, 12:21 PM
divadsn mentioned this in rWDQG2fceaa57e166: Add explanatory tooltips for GraphResultBrowser display icons.Jan 14 2017, 12:38 PM
divadsn mentioned this in rWDQGcee0fea14bc2: Add explanatory tooltips for GraphResultBrowser display icons.Jan 14 2017, 12:49 PM
divadsn mentioned this in rWDQGc0137e0cb30f: Add explanatory tooltips for GraphResultBrowser display icons.Jan 18 2017, 4:30 PM
gerritbot added a comment.Jan 19 2017, 6:37 PM

Change 332041 merged by jenkins-bot:
Add explanatory tooltips for GraphResultBrowser display icons

https://gerrit.wikimedia.org/r/332041

divadsn closed this task as Resolved.Jan 19 2017, 6:58 PM

Jenkins has successfully merged my second change, so I will close this as finally resolved! :)

divadsn mentioned this in rWDQG041d35af2cc5: Final NoteDb migration updates.Jun 11 2018, 5:02 AM
divadsn mentioned this in rWDQGc3e83a40255f: Final NoteDb migration updates.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL