Page MenuHomePhabricator
Create Task
Maniphest T137424

On SET wikis/"Remember my last editor", section edit links say "Edit" even when they mean "Edit source"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When the last editor used is WT, I expect the section edit links to also say "Edit source", just like the top one for the page does.
If this is intentional, it's confusing: I didn't know what to expect when I clicked on one of those links.

Details

SubjectRepoBranchLines +/-
DAT.init#setEditorPreference: Change section edit alongside tab labelsmediawiki/extensions/VisualEditormaster+42 -25
Customize query in gerrit

Event Timeline

• Elitre created this task.Jun 9 2016, 2:36 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 9 2016, 2:36 PM
Jdforrester-WMF triaged this task as Low priority.Jun 29 2016, 12:19 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set the point value for this task to 1.
• AlexMonk-WMF claimed this task.Jun 30 2016, 1:20 AM
• AlexMonk-WMF subscribed.

Uploaded something that should hopefully address this while Phab was down: https://gerrit.wikimedia.org/r/296680

Jdforrester-WMF subscribed.Jun 30 2016, 10:20 AM

(Only possible to vary this for logged-in editors, of course.)

• AlexMonk-WMF added a comment.Jun 30 2016, 4:10 PM

Hopefully my JS should help with logged out users but it needs better testing.

• AlexMonk-WMF added a project: Patch-For-Review.Jul 6 2016, 1:30 AM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 12 2016, 9:31 PM
gerritbot subscribed.Jul 14 2016, 4:26 PM

Change 296680 merged by jenkins-bot:
DAT.init#setEditorPreference: Change section edit alongside tab labels

https://gerrit.wikimedia.org/r/296680

Krenair closed this task as Resolved.Jul 14 2016, 4:37 PM
• AlexMonk-WMF added a comment.Jul 14 2016, 4:42 PM

(Clearly, I used the wrong account to close)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 14 2016, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits