Page MenuHomePhabricator

Intermittent sidebar corruption
Closed, ResolvedPublic

Description

This has been reported twice on enwiki:

It appears that something is loading the 'sidebar' message incorrectly, somehow the intended value is being returned as element 0 of a two-element array with element 1 being a floating point number slightly less than 30. This, instead of getting the usual sidebar with boxes for "navigation", "search", "interaction", and "tools", each with the expected links inside, we get a sidebar with a box labeled "0" having broken subitems named "Navigation", "<SEARCH>", "Interaction", and "<TOOLBOX>" and a box labeled "1" with a floating point number inside.

rMW0a38dbc809c8: objectcache: Support key versioning in WANObjectCache looks suspicious, specifically the use of the return value of $this->unwrap() near line 897. See inline comments in Gerrit.

Event Timeline

Change 294522 had a related patch set uploaded (by Aaron Schulz):
Fix WAN cache stashing bug due to missing list() call

https://gerrit.wikimedia.org/r/294522

Change 294522 merged by jenkins-bot:
Fix WAN cache stashing bug due to missing list() call

https://gerrit.wikimedia.org/r/294522

Change 294592 had a related patch set uploaded (by Aaron Schulz):
Fix WAN cache stashing bug due to missing list() call

https://gerrit.wikimedia.org/r/294592

Change 294592 merged by jenkins-bot:
Fix WAN cache stashing bug due to missing list() call

https://gerrit.wikimedia.org/r/294592

aaron claimed this task.