Page MenuHomePhabricator
Create Task
Maniphest T139836

Old version has no style for span.comment in subtitle
Closed, ResolvedPublic
Actions

Description

The style for span.comment was moved from shared to module, but it seems nobody checked where the function Linker::revComment and Linker::commentBlock are used, which produce this kind of css class.

One place where it is missed is on old revision view where it is used in the subtitle

Details

SubjectRepoBranchLines +/-
Move span.comment back to shared.css as its more widely usedmediawiki/corewmf/1.28.0-wmf.9+7 -7
Move span.comment back to shared.css as its more widely usedmediawiki/coremaster+7 -7
Customize query in gerrit

Event Timeline

Umherirrender created this task.Jul 9 2016, 9:12 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 9 2016, 9:12 AM
Danny_B renamed this task from [Regression] Old version has no style for span.comment in subtitle to Old version has no style for span.comment in subtitle.Jul 9 2016, 1:19 PM
Danny_B added a project: Regression.
• Prtksxna subscribed.Jul 10 2016, 5:13 AM
gerritbot subscribed.Jul 11 2016, 4:10 PM

Change 298171 had a related patch set uploaded (by Prtksxna):
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298171

gerritbot added a project: Patch-For-Review.Jul 11 2016, 4:10 PM
gerritbot added a comment.Jul 11 2016, 4:25 PM

Change 298171 merged by jenkins-bot:
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298171

gerritbot added a comment.Jul 11 2016, 11:39 PM

Change 298402 had a related patch set uploaded (by Jforrester):
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298402

gerritbot added a comment.Jul 11 2016, 11:47 PM

Change 298402 merged by jenkins-bot:
Move span.comment back to shared.css as its more widely used

https://gerrit.wikimedia.org/r/298402

matmarex closed this task as Resolved.Jul 12 2016, 12:39 AM
matmarex assigned this task to • Prtksxna.
matmarex triaged this task as High priority.
matmarex edited projects, added MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)), MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), MW-1.28-release-notes; removed Patch-For-Review.
Aklapper edited projects, added MediaWiki-Page-history; removed MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Sep 20 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits