Page MenuHomePhabricator

Compact language links is declared as a beta feature in our configuration but is enabled everywhere excepted by default
Closed, InvalidPublic

Description

If on a wiki, the beta feature isn't installed, compact language links is a default feature in this wiki.

UniversalLanguageSelector.hooks.php
   public static function isCompactLinksEnabled( $user ) {
        []
        if ( $wgULSCompactLanguageLinksBetaFeature === false ) {
            // Compact language links is a default feature in this wiki.
            // Check user preference
            return $user->getBoolOption( 'compact-language-links' );
        }
        []
}

And this compact-language-links preference is currently set by default to 1 in CommonSettings.

And indeed, here what happens in production:

mw1017
$ mwrepl ruwikivoyage
$  $user = User::newFromName( 'Dereckson' );
$  var_dump( UniversalLanguageSelectorHooks::isCompactLinksEnabled( $user ) );
bool(true)

Event Timeline

Change 298133 had a related patch set uploaded (by Dereckson):
Fix Compact Language Links availability issue

https://gerrit.wikimedia.org/r/298133

Change 298133 abandoned by Dereckson:
Fix Compact Language Links availability issue

Reason:
Configuration comments should be updated to reflect the feature is in prod, not beta anymore, but this fix is so not needed.

https://gerrit.wikimedia.org/r/298133

Per T136677, compact language links aren't indeed beta anymore.