Page MenuHomePhabricator

Load progress bar not visible when initialising editor from section
Closed, ResolvedPublic1 Story Points

Description

When clicking "edit" from a section heading further down the page, the page fades out and the user is left clueless for many seconds. The section they wanted to edit is moved out of their view, and no loading progress is made apparent.

  1. Open https://wikitech.wikimedia.org/w/index.php?title=Purge_2016&veaction=edit&vesection=41

Three observed issues:

  • The page seemingly scrolls a bit. This is confusing to the user and looks like an error. It is caused by layout changes along the top of the page. Those are clear and mostly innocent when editing from there, but when editing further down the page, the viewport is change is unjustified. Also, while waiting for the editor to load, the section I wanted to edit is not in my viewport.
  • Assuming the section edit process is similar to that of editing an entire page, I know a progress bar is created. However it is rendered in the middle of the first section - which is not in the user's viewport.
  • Once the editor is initialised, an attempt is made to put focus back in the selected section. This usually fails (see T97789, T106557).

Event Timeline

Krinkle created this task.Jul 11 2016, 10:35 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 11 2016, 10:35 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

Change 298485 had a related patch set uploaded (by Esanders):
Fix vertical positioning of progress bar

https://gerrit.wikimedia.org/r/298485

Change 298485 merged by jenkins-bot:
Fix vertical positioning of progress bar

https://gerrit.wikimedia.org/r/298485

Jdforrester-WMF closed this task as Resolved.Jul 12 2016, 4:35 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

LGTM.