Page MenuHomePhabricator
Create Task
Maniphest T140575

Raw HTML entity displayed with French locale
Closed, ResolvedPublic
Actions

Description

Hello,

On 1.27+e0ad10a, using the French locale, there is an HTML entity that isn't correctly displayed on Spécial:Newsletter/1:

Capture d'écran - 17072016 - 18:47:08.png (35×128 px, 1 KB)

Regards,

Details

SubjectRepoBranchLines +/-
Fixed publishers field double escaping HTMLmediawiki/extensions/Newslettermaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Rudloff created this task.Jul 17 2016, 4:50 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 17 2016, 4:50 PM
Rudloff updated the task description. (Show Details)Jul 17 2016, 4:51 PM
Aklapper renamed this task from Entity not displayed correctly with French locale to Raw HTML entity displayed with French locale.Jul 19 2016, 10:08 AM
01tonythomas added a project: Google-Code-In-2016.EditedNov 2 2016, 11:48 AM
01tonythomas subscribed.

I would love to get another one to mentor Google-Code-In-2016

01tonythomas moved this task from Proposed tasks to Missing mentors on the Google-Code-In-2016 board.Nov 2 2016, 12:02 PM
01tonythomas moved this task from Backlog to Google Code In 2016 on the MediaWiki-extensions-Newsletter board.Nov 5 2016, 4:52 PM
Abhinand subscribed.Nov 11 2016, 4:06 PM

I would like to mentor this task for Google-Code-In-2016 :)

Abhinand moved this task from Missing mentors to Proposed tasks on the Google-Code-In-2016 board.Nov 12 2016, 1:05 PM
Florian moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 15 2016, 5:15 PM
Florian subscribed.

Already imported in GCI site: https://codein.withgoogle.com/dashboard/tasks/5734050677391360/ (@Abhinand: I was free and added @01tonythomas a mentor, too, so you both can mentor this task, I hope this is ok :)).

Georggi199 claimed this task.Dec 6 2016, 8:12 PM
Georggi199 subscribed.

pasted_file (232×260 px, 13 KB)
This issue is not with french locale but with handling of text in publishers array.

Georggi199 added a comment.Dec 7 2016, 8:32 PM

https://phabricator.wikimedia.org/P4587 change is here

gerritbot subscribed.Dec 7 2016, 8:47 PM

Change 325816 had a related patch set uploaded (by Georggi199):
Fixed publishers field showing space character wrong.

https://gerrit.wikimedia.org/r/325816

gerritbot added a project: Patch-For-Review.Dec 7 2016, 8:47 PM
Abhinand added a comment.Dec 7 2016, 9:59 PM

@01tonythomas: Seems good to me. Do we need to keep the space, only for French locale?

gerritbot added a comment.Dec 8 2016, 8:48 AM

Change 325816 merged by jenkins-bot:
Fixed publishers field double escaping HTML

https://gerrit.wikimedia.org/r/325816

01tonythomas closed this task as Resolved.Dec 8 2016, 8:59 AM

Works. Thank you!

Qgil awarded a token.Dec 8 2016, 10:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL