Page MenuHomePhabricator

Unable to see which patch is the parent/dependency of specific patch
Closed, ResolvedPublic

Description

When I look at the patch, e.g. https://gerrit.wikimedia.org/r/#/c/302424/, it is very hard to see with new Gerrit UI which patches this patch relies on. There are "related changes", but they are just the list, without any dependency order, so it's unclear which one is parent and which is a child.

There's parent commit listed, but it's just a hash, which gives no information about which change it is unless you browse through all the changes and check commit hashes.

Old Gerrit UI had dependent and parent changes listed explicitly, so one can know what is the picture of patch dependency. I think this should be restored, currently it is very hard to see the picture.

Event Timeline

You can see which part is parent, but all it gives you is a commit id not the name of the patch.

We should file this upstream.

Filed upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=4341 please add any additional information I forgot to add please.

Oh I think they support this in a confussing way, it is now in Related Changes, and shows all the patches that this change needs even shows the other patches that are needed by patch you depend on. They are shown in order, and could probly clean this up to only show the one patch you depend on.

Per

dborowitz@google.com

"Related changes" *is* "dependencies", it was just renamed. In your reproduction steps, you should see both changes in the "related changes" tab.

So it was renamed, and is in order so you should now be able to tell, it is the new way.

Can we close this as declined?

No? The problem is not the label, it's the flat tree.

+ Foo
| 
+ -- + Bar
|    |
+    + Baz
|
+ -- + Bang

Merging Bang is only blocked by Foo; merging Baz is blocked by Bar and Foo. Not being able to tell where in the stack you are isn't at all helpful.

@Jdforrester-WMF Oh, could you explain that on the upstream issue please?

But it grabs all the dependancies in Related Changes now.

I've posted my explanation upstream. Please don't file upstream tasks too hastily without sufficient word-smithing and context; it wastes their time and ours.

@Jdforrester-WMF the absence of the tree is the problem, exactly. And the fact that there's no easy way to see this patch's immediate blockers. I understand you might be able to deduce it from cryptic dots on the right side of the Related Changes but I'd rather see it explicitly.

I believe how they did it was they did it in order with the patch in the centre and the parent ones at the top and the sub ones at the bottom.

Yeh PolyGerrit has a lot of improvements to the ui.

Please reopen if polygerrit dosen't fix this. But i can tell in polygerrit :).