Page MenuHomePhabricator
Create Task
Maniphest T142034

"No match found" when haven't typed anything yet into the entity suggestion search box
Closed, ResolvedPublic
Actions

Description

when adding new statements and I haven't typed anything yet (and no suggestions from property suggestor), it says "No match found".

nomatchfound.png (736×410 px, 17 KB)

I think the suggester should give the user a chance to search something (non-empty) before showing this warning.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Don't show 'nothing found' when input emptyJonas Kress (WMDE)mediawiki/extensions/Wikibasemaster+2 -1
Customize query in gerrit

Event Timeline

aude created this task.Aug 3 2016, 7:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2016, 7:58 PM
Lydia_Pintscher triaged this task as High priority.Aug 4 2016, 7:23 AM
Lydia_Pintscher added a subscriber: • Jonas.
gerritbot subscribed.Aug 4 2016, 9:23 AM

Change 302891 had a related patch set uploaded (by Jonas Kress (WMDE)):
Don't show 'nothing found' when input empty

https://gerrit.wikimedia.org/r/302891

• Jonas claimed this task.Aug 4 2016, 9:24 AM
• Jonas added a project: Wikidata-Sprint-2016-08-02.
• Jonas moved this task from Proposed to Review on the Wikidata-Sprint-2016-08-02 board.
• Jonas added a project: Patch-For-Review.Aug 4 2016, 9:29 AM
thiemowmde moved this task from incoming to in progress on the Wikidata board.Aug 4 2016, 10:03 AM
thiemowmde added a project: good first task.
thiemowmde subscribed.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 4 2016, 10:03 AM
gerritbot added a comment.Aug 4 2016, 3:11 PM

Change 302891 merged by jenkins-bot:
Don't show 'nothing found' when input empty

https://gerrit.wikimedia.org/r/302891

• Jonas closed this task as Resolved.Aug 4 2016, 8:05 PM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-08-02 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits