Page MenuHomePhabricator

Different size boxes for bundled notifications
Closed, ResolvedPublic


Found when checking T140523: In mobile view, bundled notifications extend outside the screen limit

IMG_1598.PNG (1×640 px, 77 KB)

A smaller difference.
IMG_1601.PNG (1×640 px, 88 KB)

The example of the title to produce such type of misalignment is

[[User:ETonkovidova]] on Feb 03

Surprisingly , titles like
[[User:Lorem ipsum dolor sit amet consectetur adipiscing elit Morbi vitae euismod]] is a really long user name are displayed fine.

Event Timeline

Danny_B renamed this task from [mobile] Different size boxes for bundled notifications to Different size boxes for bundled notifications .Aug 10 2016, 11:55 PM
Danny_B added a project: Mobile.
Catrope added a subscriber: Catrope.

Clarification: this is about the different widths. The different heights are expected due to wrapping.

Seems to happen when the username in the message is longer, and so the wrapping is ... well, warped.

I am not sure how to fix this. If we make the font smaller or try to accommodate the width of the username at a certain point, we will still run into issues with longer usernames.
We could truncate the username after certain amount of characters, which will work for even longer usernames...

I take this back, the behavior is not happening in Chrome mobile emulator and in Android:

Chrome mobile:

screenshot-special-notifications-wrap.png (643×357 px, 54 KB)

Chrome on Android:

screenshot-special-notifications-wrap-android.png (1×718 px, 173 KB)

Firefox on Android:

screenshot-special-notifications-wrap-android-firefox.png (1×718 px, 170 KB)

I checked on an iOS device and I can't reproduce it either there. This is either not about the length of the username/topic name, or it might be about a specific iOS version...?

@Mooeypoo There is a discrepancy in how the issue is displayed on the real device (iPhone 6s, iOS 9.3.2) and Chrome mobile emulator. However, it's still reproducible. The key points for reproducing

  • the topic title should include a link. The below examples include

[[User:ETonkovidova]] on Feb 03 new topic and [[User:FictitiousUserWithLongName]] on Feb 03 new topic

IMG_1627.PNG (1×640 px, 91 KB)

not in cross-wiki bundle
IMG_1626.PNG (1×640 px, 77 KB)

  • more noticeable in cross-wiki bundles
  • the issue is only partially displayed by Chrome emulator, but it's there (on the screenshot is cross-wiki bundle with the first message with the topic title [[User:FictitiousUserWithLongName]] on Feb 03 new topic

Screen Shot 2016-08-18 at 2.42.43 PM.png (678×647 px, 93 KB)

Change 307663 had a related patch set uploaded (by Mooeypoo):
Add the best CSS rule to notifications: word-break: break-word;

Change 307663 merged by jenkins-bot:
Add the best CSS rule to notifications: word-break: break-word;

The issue is fixed - checked in betalabs:

IMG_1653.PNG (1×640 px, 85 KB)

In a foreign wiki

IMG_1654.PNG (1×640 px, 88 KB)