Page MenuHomePhabricator

ORES format issue (whole score document is cached)
Closed, ResolvedPublic


A score document looks like this: {"score": ..., "features": ...}

We should just be caching the value under "score", but that's not happening. So the output ends up looking different depending on whether the score was cached or not.

Event Timeline

This is now deployed to labs. The cache has been cleared to clean this up and the fix has been confirmed.

Halfak triaged this task as Unbreak Now! priority.Aug 12 2016, 6:49 PM

Mentioned in SAL [2016-08-12T20:03:11Z] <Amir1> deploying ores 2ef24f2 to scb2001.codfw.wmnet (canary node) T142857

Mentioned in SAL [2016-08-12T20:07:05Z] <Amir1> deploying ores 2ef24f2 to all nodes T142857

Mentioned in SAL [2016-08-12T20:12:58Z] <halfak> running FLUSHALL on oresrdb1001 T142857

Ladsgroup added a subscriber: Ladsgroup.

Resolving, We should break the habit of not closing phab tasks in case it's UBN!