Page MenuHomePhabricator
Create Task
Maniphest T143156

UserTest::testAllRightsWithMessage() should be a structure test so it runs for extensions too
Closed, ResolvedPublic
Actions

Description

Right now UserTest::testAllRightsWithMessage() only runs with MediaWiki core unit tests. To make it run for all extensions too, we should make it a structure test (tests/phpunit/structure).

Details

SubjectRepoBranchLines +/-
Check for right-* messages as a structure testmediawiki/coremaster+32 -30
Customize query in gerrit

Event Timeline

Legoktm created this task.Aug 16 2016, 9:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2016, 9:17 PM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:11 AM
gerritbot subscribed.Jul 26 2018, 9:16 PM

Change 448155 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Check for right-* messages as a structure test

https://gerrit.wikimedia.org/r/448155

gerritbot added a project: Patch-For-Review.Jul 26 2018, 9:16 PM
Jdforrester-WMF closed this task as Resolved.Jul 26 2018, 10:08 PM
Jdforrester-WMF assigned this task to Legoktm.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Yay.

gerritbot added a comment.Jul 26 2018, 10:34 PM

Change 448155 merged by jenkins-bot:
[mediawiki/core@master] Check for right-* messages as a structure test

https://gerrit.wikimedia.org/r/448155

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 26 2018, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits