Page MenuHomePhabricator
Create Task
Maniphest T143357

"ext.globalCssJs.user.styles" loaded before site styles marker instead of after
Closed, ResolvedPublic
Actions

Description

The load position (and with that, the cascading styles order) unintentionally changed recently.

Most likely due to rMW80e5b160e098: resourceloader: Move queue formatting out of OutputPage.

It kept the exempt positions for core modules, but not for extension modules with group=user. We'll need to make the exempt logic a bit more flexible so that it also considers any other arbitrary module passed to addModuleStyles() if it has group 'user' or 'site'.

Details

SubjectRepoBranchLines +/-
OutputPage: Make ResourceLoader position exemption more genericmediawiki/corewmf/1.28.0-wmf.15+75 -73
OutputPage: Make ResourceLoader position exemption more genericmediawiki/coremaster+75 -73
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Aug 18 2016, 8:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2016, 8:26 PM
Krinkle triaged this task as High priority.Aug 18 2016, 8:27 PM
Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.
Legoktm subscribed.Aug 18 2016, 8:27 PM
Krinkle claimed this task.Aug 18 2016, 11:06 PM
Krinkle moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Aug 18 2016, 11:11 PM
Volker_E subscribed.Aug 19 2016, 12:59 AM
gerritbot subscribed.Aug 19 2016, 2:19 AM

Change 305609 had a related patch set uploaded (by Krinkle):
OutputPage: Make ResourceLoader position exemption more generic

https://gerrit.wikimedia.org/r/305609

gerritbot added a project: Patch-For-Review.Aug 19 2016, 2:19 AM
gerritbot added a comment.Aug 19 2016, 4:37 AM

Change 305609 merged by jenkins-bot:
OutputPage: Make ResourceLoader position exemption more generic

https://gerrit.wikimedia.org/r/305609

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 19 2016, 5:00 AM
gerritbot added a comment.Aug 19 2016, 6:19 AM

Change 305618 had a related patch set uploaded (by Krinkle):
OutputPage: Make ResourceLoader position exemption more generic

https://gerrit.wikimedia.org/r/305618

gerritbot added a comment.Aug 19 2016, 6:27 AM

Change 305618 merged by jenkins-bot:
OutputPage: Make ResourceLoader position exemption more generic

https://gerrit.wikimedia.org/r/305618

Stashbot subscribed.Aug 19 2016, 6:32 AM

Mentioned in SAL [2016-08-19T06:32:21Z] <krinkle@tin> Synchronized php-1.28.0-wmf.15/includes/OutputPage.php: T143357 (duration: 00m 55s)

Krinkle closed this task as Resolved.Aug 19 2016, 6:32 AM
Krinkle moved this task from Confirmed Problem to Assigned on the MediaWiki-ResourceLoader board.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 19 2016, 7:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits