Page MenuHomePhabricator
Create Task
Maniphest T144094

debian-glue test fails with Unrecognized macro 'BUILD_TIMEOUT' in '${BUILD_TIMEOUT}'
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

Actual results

  • Jenkins quickly fails with
14:47:07 FATAL: Could not evaluate macro
14:47:07 org.jenkinsci.plugins.tokenmacro.MacroEvaluationException: Unrecognized macro 'BUILD_TIMEOUT' in '${BUILD_TIMEOUT}'
14:47:07 	at org.jenkinsci.plugins.tokenmacro.TokenMacro.expand(TokenMacro.java:207)

Caused by https://github.com/wikimedia/integration-config/commit/7e9fda82ad7e03aa1fda8314cc02c5a0011aa99d

Expected results

  • Jenkins should be able to build the deb without it failing with the above error.

Details

SubjectRepoBranchLines +/-
Create a customised debian-glue testintegration/configmaster+23 -13
Always set BUILD_TIMEOUT for debian-glue jobsintegration/configmaster+6 -0
Fix BUILD_TIMEOUT env not being added to jenkinsintegration/configmaster+7 -3
Customize query in gerrit

Event Timeline

Paladox created this task.Aug 27 2016, 3:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2016, 3:11 PM
gerritbot subscribed.Aug 27 2016, 3:11 PM

Change 307067 had a related patch set uploaded (by Paladox):
Create a customised debian-glue test

https://gerrit.wikimedia.org/r/307067

gerritbot added a project: Patch-For-Review.Aug 27 2016, 3:11 PM
Paladox triaged this task as High priority.Aug 27 2016, 4:18 PM
Paladox added a project: Continuous-Integration-Infrastructure.

Making this high priority due to breakage of test that affects other repos too.

hashar updated the task description. (Show Details)Aug 27 2016, 7:54 PM

Looks like the default parameters of the job are not applied :/

Paladox added a comment.Aug 27 2016, 7:56 PM

@hashar oh would you know how we can get the default parameters to be applied please?

Stashbot subscribed.Aug 27 2016, 8:06 PM

Mentioned in SAL [2016-08-27T20:05:46Z] <hashar> Jenkins added global env variable BUILD_TIMEOUT set to 30 for T144094

hashar added a comment.Aug 27 2016, 8:06 PM

In Jenkins I have added the global env variable BUILD_TIMEOUT set to 30. That fix it

Paladox added a comment.Aug 27 2016, 8:08 PM

Thanks. Will need to some how get it added in that yaml file.

gerritbot added a comment.Aug 27 2016, 8:11 PM

Change 307079 had a related patch set uploaded (by Hashar):
Always set BUILD_TIMEOUT for debian-glue jobs

https://gerrit.wikimedia.org/r/307079

gerritbot added a comment.Aug 27 2016, 8:11 PM

Change 307080 had a related patch set uploaded (by Paladox):
Fix BUILD_TIMEOUT env not being added to jenkins

https://gerrit.wikimedia.org/r/307080

gerritbot added a comment.Aug 27 2016, 8:12 PM

Change 307080 abandoned by Paladox:
Fix BUILD_TIMEOUT env not being added to jenkins

https://gerrit.wikimedia.org/r/307080

hashar lowered the priority of this task from High to Medium.Aug 27 2016, 8:12 PM
gerritbot added a comment.Aug 27 2016, 8:15 PM

Change 307079 merged by jenkins-bot:
Always set BUILD_TIMEOUT for debian-glue jobs

https://gerrit.wikimedia.org/r/307079

hashar closed this task as Resolved.Aug 27 2016, 8:19 PM
hashar claimed this task.

Did rechec on https://gerrit.wikimedia.org/r/#/c/307060/ , once with the global env set, and then with the zuul parameter patch applied.

gerritbot added a comment.Sep 5 2016, 10:28 AM

Change 307067 abandoned by Hashar:
Create a customised debian-glue test

Reason:
Failure to pass the BUILD_TIMEOUT env variable as been solved differently. Namely by setting it in the Jenkins global config and having Zuul to always inject it.

https://gerrit.wikimedia.org/r/307067

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL