Page MenuHomePhabricator

Do not call API when there is no missing data
Closed, ResolvedPublic

Description

In some cases, there could be a situation where all needed data groups have already been requested from the server via the query api, but haven't been received yet. We shouldn't make another api call with the empty group list.

Event Timeline

Yurik created this task.Sep 3 2016, 3:14 PM
Restricted Application added a project: Discovery. · View Herald TranscriptSep 3 2016, 3:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 308334 had a related patch set uploaded (by Yurik):
Only call API if missing groups data

https://gerrit.wikimedia.org/r/308334

@Yurik I'm not sure when this happens...

Yurik added a comment.Sep 5 2016, 3:32 PM

This would happen in VW if there are two maplinks that both have the same data, and you click first, close it, and click the second, before the data is loaded. So you will have promises for the data that you have to wait for, but you won't need to call the api.

JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Sep 5 2016, 5:06 PM

Change 308334 merged by jenkins-bot:
Only call API if missing groups data

https://gerrit.wikimedia.org/r/308334

JGirault closed this task as Resolved.Sep 5 2016, 5:08 PM

Thanks @Yurik !