Page MenuHomePhabricator

Do not call API when there is no missing data
Closed, ResolvedPublic


In some cases, there could be a situation where all needed data groups have already been requested from the server via the query api, but haven't been received yet. We shouldn't make another api call with the empty group list.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 308334 had a related patch set uploaded (by Yurik):
Only call API if missing groups data

@Yurik I'm not sure when this happens...

This would happen in VW if there are two maplinks that both have the same data, and you click first, close it, and click the second, before the data is loaded. So you will have promises for the data that you have to wait for, but you won't need to call the api.

Change 308334 merged by jenkins-bot:
Only call API if missing groups data