Page MenuHomePhabricator
Create Task
Maniphest T145405

Add position increment gap only to fields where positions are stored
Closed, ResolvedPublic
Actions

Description

This is a breaking change introduced in elasticsearch 2.4: https://github.com/elastic/elasticsearch/pull/19510
We need to change our analysis settings to not set this value for fields where positions are not stored.

Details

SubjectRepoBranchLines +/-
Only set position_increment_gap on fields where positions are storedmediawiki/extensions/CirrusSearchmaster+0 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

dcausse created this task.Sep 12 2016, 3:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2016, 3:22 PM
dcausse added a project: CirrusSearch.Sep 12 2016, 3:22 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptSep 12 2016, 3:22 PM
dcausse added a parent task: T145199: Upgrade elasticsearch plugins to 2.4.0.Sep 12 2016, 3:23 PM
debt triaged this task as Medium priority.Sep 12 2016, 3:44 PM
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse claimed this task.Sep 13 2016, 2:27 PM
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.Sep 13 2016, 2:27 PM

Change 310310 had a related patch set uploaded (by DCausse):
Only set position_increment_gap on fields where positions are stored

https://gerrit.wikimedia.org/r/310310

gerritbot added a project: Patch-For-Review.Sep 13 2016, 2:27 PM
dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Sep 13 2016, 2:28 PM
gerritbot added a comment.Sep 14 2016, 1:13 AM

Change 310310 merged by jenkins-bot:
Only set position_increment_gap on fields where positions are stored

https://gerrit.wikimedia.org/r/310310

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)).Sep 14 2016, 2:00 AM
dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Sep 15 2016, 8:18 AM
debt closed this task as Resolved.Sep 23 2016, 9:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL