Page MenuHomePhabricator
Create Task
Maniphest T145686

Main screen should support dark mode?
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Question for design and product: should the main screen support dark mode?

Details

SubjectRepoBranchLines +/-
Allow Dark mode for MainActivity.apps/android/wikipediamaster+7 -10
Customize query in gerrit

Related Objects

Event Timeline

• Niedzielski created this task.Sep 14 2016, 8:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2016, 8:45 PM
Dbrant mentioned this in T146109: [BUG] Language picker is unreadable in dark theme.Sep 21 2016, 4:55 PM
Dbrant moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App-Backlog board.
gerritbot subscribed.Sep 21 2016, 9:53 PM

Change 312119 had a related patch set uploaded (by Dbrant):
Allow Dark mode for MainActivity.

https://gerrit.wikimedia.org/r/312119

gerritbot added a project: Patch-For-Review.Sep 21 2016, 9:53 PM
Dbrant claimed this task.Sep 22 2016, 1:49 PM
Dbrant added a project: Mobile-App-Android-Sprint-91-Protactinium.
Dbrant moved this task from To Do to Code Review on the Mobile-App-Android-Sprint-91-Protactinium board.
gerritbot added a comment.Sep 22 2016, 4:13 PM

Change 312119 merged by jenkins-bot:
Allow Dark mode for MainActivity.

https://gerrit.wikimedia.org/r/312119

Dbrant moved this task from Code Review to Design Signoff on the Mobile-App-Android-Sprint-91-Protactinium board.Sep 22 2016, 10:10 PM
Dbrant set the point value for this task to 1.Sep 23 2016, 1:27 PM
Dbrant added a project: Mobile-App-Android-Sprint-92-Uranium.Sep 26 2016, 12:59 PM
Dbrant moved this task from To Do to Design Signoff on the Mobile-App-Android-Sprint-92-Uranium board.Sep 26 2016, 1:07 PM
• Nirzar subscribed.Sep 28 2016, 1:52 AM

@Niedzielski I have to kill the app for this to work? it won't switch to dark right away

• Niedzielski added a comment.Sep 28 2016, 4:09 AM

Supporting dark mode in the main screen is a feature that was added per this task. A lame bug was later found as you mentioned (T146725). Thanks for checking this out and following up.

Dbrant moved this task from Design Signoff to Done on the Mobile-App-Android-Sprint-92-Uranium board.Sep 29 2016, 1:49 PM
Dbrant closed this task as Resolved.Sep 29 2016, 1:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL