Page MenuHomePhabricator
Create Task
Maniphest T145774

Missing fullscreen close button title message
Closed, ResolvedPublic
Actions

Description

firefox_2016-09-15_22-55-20.png (94×197 px, 5 KB)

Message seems to exist, it's just not loaded.

Details

SubjectRepoBranchLines +/-
Move CloseFullScreenControl to the dialog module.mediawiki/extensions/Kartographermaster+22 -23
Add missing close button title messagemediawiki/extensions/Kartographerwmf/1.28.0-wmf.19+2 -1
Add missing close button title messagemediawiki/extensions/Kartographermaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Majr created this task.Sep 15 2016, 12:57 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptSep 15 2016, 12:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Sep 15 2016, 3:28 PM

Change 310833 had a related patch set uploaded (by JGirault):
Add missing close button title message

https://gerrit.wikimedia.org/r/310833

gerritbot added a project: Patch-For-Review.Sep 15 2016, 3:28 PM
• JGirault added a project: Maps-Sprint.Sep 15 2016, 3:28 PM
• JGirault moved this task from Unsorted to UI tasks on the Maps (Kartographer) board.
• JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.
gerritbot added a comment.Sep 15 2016, 4:08 PM

Change 310850 had a related patch set uploaded (by JGirault):
Move CloseFullScreenControl to the dialog module.

https://gerrit.wikimedia.org/r/310850

gerritbot added a comment.Sep 15 2016, 4:10 PM

Change 310851 had a related patch set uploaded (by Yurik):
Add missing close button title message

https://gerrit.wikimedia.org/r/310851

gerritbot added a comment.Sep 15 2016, 4:11 PM

Change 310833 merged by jenkins-bot:
Add missing close button title message

https://gerrit.wikimedia.org/r/310833

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)).Sep 15 2016, 5:00 PM
gerritbot added a comment.Sep 15 2016, 6:33 PM

Change 310851 merged by jenkins-bot:
Add missing close button title message

https://gerrit.wikimedia.org/r/310851

Stashbot subscribed.Sep 15 2016, 6:36 PM

Mentioned in SAL (#wikimedia-operations) [2016-09-15T18:36:58Z] <thcipriani@tin> Started scap: SWAT: [[gerrit:310851|Add missing close button title message (T145774)]] and [[gerrit:310872|Revert "Remove jquery.arrowSteps module" (T144974)]]

Stashbot mentioned this in T144974: Move jquery.arrowSteps to UploadWizard and remove unnecessary code.Sep 15 2016, 6:36 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 15 2016, 7:00 PM
Stashbot added a comment.Sep 15 2016, 7:05 PM

Mentioned in SAL (#wikimedia-operations) [2016-09-15T19:05:06Z] <thcipriani@tin> Finished scap: SWAT: [[gerrit:310851|Add missing close button title message (T145774)]] and [[gerrit:310872|Revert "Remove jquery.arrowSteps module" (T144974)]] (duration: 28m 08s)

• JGirault closed this task as Resolved.Sep 15 2016, 7:10 PM
gerritbot added a comment.Sep 15 2016, 7:17 PM

Change 310850 merged by jenkins-bot:
Move CloseFullScreenControl to the dialog module.

https://gerrit.wikimedia.org/r/310850

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits